Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(editor): connections lost when renaming #3899

Merged
merged 1 commit into from
Aug 19, 2022
Merged

fix(editor): connections lost when renaming #3899

merged 1 commit into from
Aug 19, 2022

Conversation

mutdmour
Copy link
Contributor

No description provided.

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Aug 18, 2022
@ivov ivov mentioned this pull request Aug 19, 2022
Closed
MiloradFilipovic
MiloradFilipovic approved these changes Aug 19, 2022
View reviewed changes
Copy link
Contributor

@MiloradFilipovic MiloradFilipovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Tried testing as many cases where getCurrentWorkflow() is used as I can think of and it seems to work fine.

@MiloradFilipovic MiloradFilipovic merged commit ad0c214 into master Aug 19, 2022
@MiloradFilipovic MiloradFilipovic deleted the n8n-4353-rename-bug branch August 19, 2022 08:12
@n8n-assistant n8n-assistant bot added the Upcoming Release Will be part of the upcoming release label Aug 19, 2022
@Joffcom Joffcom mentioned this pull request Aug 19, 2022
Closed
@janober
Copy link
Member

janober commented Aug 19, 2022

Got released with n8n@0.191.1

@janober janober removed the Upcoming Release Will be part of the upcoming release label Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiloradFilipovic MiloradFilipovic MiloradFilipovic approved these changes

Assignees
No one assigned
Labels
n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mutdmour @janober @MiloradFilipovic