Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(editor): Show input number for multi-input nodes #4000

Merged
merged 5 commits into from
Sep 13, 2022

Conversation

OlegIvaniv
Copy link
Contributor

@OlegIvaniv OlegIvaniv added ui Enhancement in /editor-ui or /design-system n8n team Authored by the n8n team labels Sep 1, 2022
@OlegIvaniv OlegIvaniv requested a review from mutdmour September 1, 2022 14:41
@OlegIvaniv OlegIvaniv self-assigned this Sep 1, 2022
packages/editor-ui/src/plugins/i18n/locales/en.json Outdated Show resolved Hide resolved
packages/editor-ui/src/constants.ts Outdated Show resolved Hide resolved
packages/editor-ui/src/components/InputPanel.vue Outdated Show resolved Hide resolved
Copy link
Contributor

@mutdmour mutdmour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@OlegIvaniv OlegIvaniv merged commit 8c95d6e into master Sep 13, 2022
@OlegIvaniv OlegIvaniv deleted the n8n-4444-designate-the-input-number-in-the-input branch September 13, 2022 13:42
@n8n-assistant n8n-assistant bot added the Upcoming Release Will be part of the upcoming release label Sep 13, 2022
@janober
Copy link
Member

janober commented Sep 15, 2022

Got released with n8n@0.194.0

valya pushed a commit to valya/n8n that referenced this pull request Nov 8, 2022
* feat(editor): Show input number for multi-input nodes

* ✨ Added multiple inputs detection logic to input panel

* 🐛 Fix a case where Input 1 and Input 2 are identical, do not display nodeIndex for single input nodes

* 🔥 Delete unused `MERGE_NODE_TYPE` constant

* ♻️ Get input names dynamically for multi-input nodes

Co-authored-by: Milorad Filipovic <milorad@n8n.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants