Read-only workflow executions allow code editing in Function node

[ed-parsadanyan]

Describe the bug
n8n allows to review past executions (either failed or successful). During the review process most of the items are locked due to "read only" mode. However, JS code in the Function is editable.

To Reproduce
Steps to reproduce the behavior:

1. Create a workflow with a Function Node
2. Modify workflow settings "Save successful executions" = Save
3. Run the workflow, then open past execution
4. Click on the Function node and then the code editor. The code can be changed.

Expected behavior
Code editing is not allowed when viewing past executions

Environment (please complete the following information):

• OS: Ubuntu Linux 22.04
• n8n Version 0.193.3
• Node.js Version NA - docker version
• Database system postgresql
• Operation mode main

[Joffcom]

Hey @ed-parsadanyan,

Thanks for reporting this one, does it let you save the edit as well or only edit it while you are looking at it?

[ed-parsadanyan]

It asks me "Save changes before leaving?", when I press "Yes" and come back again it doesn't seem to save anything.

HOWEVER, new workflows with the same name are created:

The workflow with a tag is the original one created yesterday. Several new ones from today were created after I pressed "Save" during the review process of the past execution