Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): load nodes and credentials on windows using the correct file-path #4084

Merged
merged 1 commit into from
Sep 12, 2022
Merged

fix(cli): load nodes and credentials on windows using the correct file-path #4084

merged 1 commit into from
Sep 12, 2022
+3 −0

Conversation

netroy
Copy link
Member

@netroy netroy commented Sep 12, 2022

No description provided.

@netroy netroy requested review from Joffcom and maspio September 12, 2022 16:08
@netroy netroy changed the title fix(cli): load nodes and credentials on windows using the correct file-path fix(cli): load nodes and credentials on windows using the correct file-path - N8N-4596 Sep 12, 2022
@netroy netroy changed the title fix(cli): load nodes and credentials on windows using the correct file-path - N8N-4596 fix(cli): load nodes and credentials on windows using the correct file-path Sep 12, 2022
Joffcom
Joffcom approved these changes Sep 12, 2022
View reviewed changes
Copy link
Member

@Joffcom Joffcom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me on Win 10

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Sep 12, 2022
@netroy netroy merged commit b6c1187 into master Sep 12, 2022
@netroy netroy deleted the fix-N8N-4596 branch September 12, 2022 16:48
@n8n-assistant n8n-assistant bot added the Upcoming Release Will be part of the upcoming release label Sep 12, 2022
@janober
Copy link
Member

janober commented Sep 15, 2022

Got released with n8n@0.194.0

@janober janober removed the Upcoming Release Will be part of the upcoming release label Sep 15, 2022
valya pushed a commit to valya/n8n that referenced this pull request Nov 8, 2022
@netroy
fix(cli): load nodes and credentials on windows using the correct fil…
5d3fb98 
…e-path (n8n-io#4084)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maspio maspio maspio approved these changes

@Joffcom Joffcom Joffcom approved these changes

Assignees
No one assigned
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@netroy @janober @Joffcom @maspio