fix(expression): prevent calls to constructor to forbid arbitrary code execution #4139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
core
ivov
previously approved these changes
Sep 19, 2022
There was a problem hiding this comment.
Confirmed working.
Minor details, feel free to disregard:
\sseems unneeded as standaloneconstructoris already in the denylist.mmultiline mode seems unneeded as multiline expressions don't resolve.- Maybe
contains invalid constructor callto make it clear to the user what the issue is, sincecauseDetailedis not visible in the UI.
|
We used a regex in the past to solve other security issues. It caused a lot of problems (mainly broke workflows because of false positives) and we then had to roll it back. Is there no other way of fixing this? |
|
@janober I thought about changing the prototype but then it would also leak to the main code. This is only preventing |
ivov
approved these changes
Sep 19, 2022
n8n-assistant
bot
added
the
Upcoming Release
|
Got released with |
valya
pushed a commit
to valya/n8n
that referenced
this pull request
Nov 8, 2022
…e execution (n8n-io#4139) * fix(expression): prevent calls to constructor to forbid arbitrary code execution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.