Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor-ui): Fix ParameterInput inputField ref focus #4215

Merged
merged 2 commits into from
Sep 28, 2022

Conversation

OlegIvaniv
Copy link
Contributor

@OlegIvaniv OlegIvaniv commented Sep 27, 2022

N8N-4783

The CredentialsSelect component doesn't implement focus method, so we need to add one to trigger select focus.

@OlegIvaniv OlegIvaniv requested a review from mutdmour September 27, 2022 15:43
@OlegIvaniv OlegIvaniv self-assigned this Sep 27, 2022
@linear
Copy link

linear bot commented Sep 27, 2022

N8N-4783

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Sep 27, 2022
@OlegIvaniv OlegIvaniv merged commit ed40397 into master Sep 28, 2022
@OlegIvaniv OlegIvaniv deleted the n8n-4783-focusing-input-in-parametersinput-throws branch September 28, 2022 07:46
@n8n-assistant n8n-assistant bot added the Upcoming Release Will be part of the upcoming release label Sep 28, 2022
@janober
Copy link
Member

janober commented Sep 30, 2022

Got released with n8n@0.196.0

@janober janober removed the Upcoming Release Will be part of the upcoming release label Sep 30, 2022
valya pushed a commit to valya/n8n that referenced this pull request Nov 8, 2022
* fix(editor-ui): Fix ParameterInput inputField ref focus

* 🐛 Add focus method for `CredentialsSelect` and revert previous change to `ParamterInput`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants