fix(KoboToolbox Node): fix hook logs not working correctly #4286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Yann-J
commented
Oct 7, 2022
Yann-J
commented
- Support more hook log API parameters
- Fix hook log retry
n8n-assistant
bot
added
community
|
Hey @Yann-J, It looks like you have removed the actions which we have added to all Operation options, They will need to be added back in before we can merge this. With the change to Hook Logs if I was previously using Limit or Return All in my workflow what is going to happen now with this change? |
|
OK, done, I guess I didn't know what those were... |
|
Regarding the changes to Get Hook Logs, the pagination was never working. This API does in fact not support pagination, only date filters. |
|
Hey @Yann-J, Perfect in that case as it won't really break anything we can run with that and get it merged. With the Action we added it for a future feature to all of the nodes. |
Joffcom
approved these changes
Oct 12, 2022
Joffcom
changed the title
n8n-assistant
bot
added
the
Upcoming Release
|
Got released with |
valya
pushed a commit
to valya/n8n
that referenced
this pull request
Nov 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.