Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Notion (Beta) Node): Use resource locator component for database and page parameters #4340

Merged
merged 42 commits into from
Nov 11, 2022
Merged

feat(Notion (Beta) Node): Use resource locator component for database and page parameters #4340

merged 42 commits into from
Nov 11, 2022

Conversation

maspio
Copy link
Contributor

@maspio maspio commented Oct 13, 2022

No description provided.

@linear
Copy link

linear bot commented Oct 13, 2022

N8N-4972

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team node/improvement New feature or request labels Oct 13, 2022
maspio added 22 commits October 14, 2022 11:33
@maspio
Merge branch 'master' into n8n-4972-notion-node-roll-out-resource-loc…
1c6c435 
…ator
@maspio
getDatabases search function for V1/V2 with url
1aca7a2
@maspio
updated database get list placeholder
7eed932
@maspio
get database RLC by url - regex support optional workspace domain names
394f7a3
@maspio
fixed linting error
b10edeb
@maspio
listSearch getDatabases support filter query
bdcfdd0
@maspio
Merge branch 'master' into n8n-4972-notion-node-roll-out-resource-loc…
43fc9bb 
…ator
@maspio
support extractValue in getCurrentNodeParameter for RLC
dc0ca3a
@maspio
RLC for database page create/getAll operation
c1491ed
@maspio
RLC for database get operation support "By ID" with optional v param.
d431130
@maspio
use RLC in append blocks operation
b220304
@maspio
use RLC in NotionTrigger.nodes.ts
40834e7
@maspio
removed unused loadOptions getDatabases
fe6dde9
@maspio
support database RLC in createPage/createDbPage operation
1124ca2
@maspio
page create operation use RLC for parent page param
cdb80e8
@maspio
page archive operation use RLC for page param
c8cc23a
@maspio
removed unused imports
5b04d0b
@maspio
fixed missing extractPageId in NotionV1.node.ts
19f2d21
@maspio
database page get operation use RLC for page param
59430a4
@maspio
database page update operation use RLC for page param
ccecf8c
@maspio
block getAll children operation use RLC for page param
227897c
@maspio
block append operation use RLC for block param
a1598f4
@maspio maspio marked this pull request as ready for review October 19, 2022 11:56
@Joffcom Joffcom changed the title feat(Notion Node): use resource locator component for database and page parameters feat(Notion (Beta) Node): use resource locator component for database and page parameters Oct 26, 2022
@maspio maspio changed the title feat(Notion (Beta) Node): use resource locator component for database and page parameters feat(Notion (Beta) Node): Use resource locator component for database and page parameters Nov 9, 2022
agobrech
agobrech approved these changes Nov 10, 2022
View reviewed changes
Copy link
Contributor

@agobrech agobrech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks technically correct, one question why don't we have the RLC for the users? If it was descope previously please ignore and merge.

@maspio
Copy link
Contributor Author

maspio commented Nov 11, 2022

@agobrech To be honest I initially didn't include it into RLC and it didn't come up in any of the reviews (never talked about). Will talk to Max if we keep it like that.

@maspio maspio merged commit 277b6b7 into master Nov 11, 2022
@maspio maspio deleted the n8n-4972-notion-node-roll-out-resource-locator branch November 11, 2022 12:37
@n8n-assistant n8n-assistant bot added the Upcoming Release Will be part of the upcoming release label Nov 11, 2022
@janober
Copy link
Member

janober commented Nov 17, 2022

Got released with n8n@0.203.0

@janober janober removed the Upcoming Release Will be part of the upcoming release label Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agobrech agobrech agobrech approved these changes

Assignees
No one assigned
Labels
n8n team Authored by the n8n team node/improvement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maspio @janober @agobrech