Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Todoist: migration to new API versions is needed before Nov 30 #4430

Closed
Schnouki opened this issue Oct 24, 2022 · 9 comments · Fixed by #4650
Closed

Todoist: migration to new API versions is needed before Nov 30 #4430

Schnouki opened this issue Oct 24, 2022 · 9 comments · Fixed by #4650
Assignees
Labels
node/issue Issue with a node

Comments

@Schnouki
Copy link
Contributor

Describe the bug
The n8n Todoist node is currently using the Todoist REST v1 API (and the Sync v8 API for moving tasks across projects). These API versions will both be deprecated on Nov 30, and all clients should use the REST v2 and Sync v9 APIs instead:

Between REST v1 and v2, some fields are renamed, and most importantly, all ID types are changed from integers to strings. (At the moment, current int IDs can safely be converted to strings.)

I'm not comfortable enough with Typescript and the n8n codebase to do it myself (especially for the part about migration IDs to a different type), but as a Todoist backend developer and n8n user, I'm willing to help 🙂

To Reproduce
Steps to reproduce the behavior:

  • it's not broken yet, but REST API v1 and Sync API v8 will be deprecated on Nov 30.

Expected behavior
I'd love if n8n continued working after Nov 30 😅

Environment (please complete the following information):

  • OS: any
  • n8n Version: git master
  • Node.js Version: any
@Joffcom
Copy link
Member

Joffcom commented Oct 25, 2022

Hey @Schnouki,

Thanks for reporting this one, I am going to take a look later today to see what we need to do. I am sure we will be all good to have any changes added before November 30th.

@Joffcom Joffcom self-assigned this Oct 25, 2022
@Joffcom
Copy link
Member

Joffcom commented Oct 25, 2022

Hey @Schnouki,

Quick update, It doesn't look like the change will be that bad although one thing I have noticed is the docs say the v8 Sync API will be removed on October 31st and v1 REST on November 30th so we may have to get this sorted this week.

I have created an internal ticket for this one which we will be tracking as n8n-5226

@Joffcom Joffcom added the node/issue Issue with a node label Oct 25, 2022
@Schnouki
Copy link
Contributor Author

Schnouki commented Oct 28, 2022

Hey @Joffcom,

Sorry, looks like the docs were not updated immediately, but I confirm that Sync v8 will be removed on Nov 30 only. It was initially announced for Oct 31st, but we postponed that; this was announced a few days ago in our API mailing list. We also updated the banner in our docs. So, no need to rush it this week 🙂

@Joffcom
Copy link
Member

Joffcom commented Oct 28, 2022

Perfect that makes life easier thanks @Schnouki

@Joffcom
Copy link
Member

Joffcom commented Nov 16, 2022

Hey @Schnouki,

Thought I would let you know that I have started to work on this, Found a couple of little things that need tweaking but it is mostly looking good.

@Schnouki
Copy link
Contributor Author

Thanks for the heads-up, @Joffcom! Again, if you need any help from our side, feel free to ask 😊

@lukasz18dg
Copy link

@Joffcom , @Schnouki , did you have plan to merge MR?
I am asking, because deadline of update is soon also I hit "brownouts" on Todoist API ( https://groups.google.com/a/doist.com/g/todoist-api/c/33g1sC_ov3Q ), where API just returned information about change version of API or did you have some workaround to avoid problem?

@Joffcom
Copy link
Member

Joffcom commented Nov 29, 2022

Hey @lukasz18dg & @Schnouki,

I was away last week but did a quick test yesterday when I got back and passed it over for review, This has been merged and will be in the next release so there may be a few hours of it not working but all will be good when we do the next release later this week.

@Schnouki
Copy link
Contributor Author

Great news, thanks a lot @Joffcom!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
node/issue Issue with a node
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants