feat(core): reimplement blocking workflow updates on interim changes #4446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivov
changed the title
n8n-assistant
bot
added
core
krynble
previously approved these changes
Oct 26, 2022
Comment on lines
+103
to
+111
| const state = JSON.stringify({ | ||
| name, | ||
| active, | ||
| nodes, | ||
| connections, | ||
| settings, | ||
| staticData, | ||
| pinData, | ||
| }); |
There was a problem hiding this comment.
I think we should simplify this to use only nodes and connections. Maybe pinData.
This reduces the chance of having issues with unnecessary warnings such as name changes or activation status.
There was a problem hiding this comment.
Thanks! As discussed, any editable parts of the workflow that we exclude from the hash will cause changes to those parts to be overwritable, which we likely do not want, so keeping it strict for now.
| @@ -355,6 +355,14 @@ workflowsController.patch( | |||
| ); | |||
| } | |||
|
|
|||
| if (incomingHash !== shared.workflow.hash) { | |||
There was a problem hiding this comment.
Can we make this check only if the payload contains nodes and connections? Perhaps pinData too?
This reduces the chance of us making checks and warnings unnecessarily.
krynble
approved these changes
Oct 27, 2022
ivov
deleted the
n8n-5237-reimplement-blocking-interim-workflow-updates
branch
n8n-assistant
bot
added
the
Upcoming Release
|
Got released with |
valya
pushed a commit
to valya/n8n
that referenced
this pull request
Nov 8, 2022
…8n-io#4446) * 📘 Update request type * 📘 Update FE types * ⚡ Adjust store * ⚡ Set received hash * ⚡ Send and load hash * ⚡ Make helper more flexible * 🗃️ Add new field to entity * 🚨 Add check to endpoint * 🧪 Add tests * ⚡ Add `forceSave` flag * 🐛 Fix workflow update failing on new workflow * 🧪 Add more tests * ⚡ Move check to `updateWorkflow()` * ⚡ Refactor to accommodate latest changes * 🧪 Refactor tests to keep them passing * ⚡ Improve syntax
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #4397