-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(editor): Add 'Stop execution' button to execution preview #4632
fix(editor): Add 'Stop execution' button to execution preview #4632
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found the following. No deep context so if any are intended, please disregard.
- Stopping a running execution triggers two toasts: error for
Problem in node ‘On clicking 'execute'‘ Workflow-Execution has been canceled!
(non-auto-dismissing) and success forExecution stopped. Execution ID X
(auto-dismissing). I would think only the success toast is enough. - Selecting a stopped execution from the executions view triggers
Workflow-Execution has been canceled!
. I would not expect to see this toast again when selecting an old execution. - Retrying a stopped execution triggers
Retry unsuccessful
every time. The workflow is a simple Manual Trigger and Wait so it should be able to retry. - Selecting a failed retry of a stopped execution triggers
"Cannot read properties of undefined (reading 'node')"
- Setting up a lengthy execution and switching to Executions view auto-selects the last already completed execution, but I would expect the running execution to be auto-selected.
Disabling nodes in Workflow view is broken, have not tested if coming from master. Edit: Disregard, this is on master.
@ivov I would say this is all expected. Here's the reasoning: 1., 2. and 4. These popups were discussed when implementing this feature and we decided to keep all messages from the old execution preview. I just now talked with Max and the agreement is to remove the Failed execution messages that appear and pile up when opening failed executions. Also we agreed to be conservative with removing popups so we don't remove anything useful. Deleting mentioned popup will already clear a lot of clutter so I'll do this in next commit. 3. I don't have much context on this, but retrying stopped executions hasn't been possible in previous versions also (just tested 5. Executions tab always remembers the last selected execution, so that one will be automatically opened when switching to it (or the first one if it's opened for the first time or remembered execution is not longer available). Let me know if this all seems reasonable. |
Got released with |
This PR introduces a few visual changes to the preview for running executions:
Stop execution
button