Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs in dynamodb connector - Fixes #4956 #4957 #4959

Merged
merged 2 commits into from
Dec 22, 2022

Conversation

napter
Copy link
Contributor

@napter napter commented Dec 19, 2022

Bug 1) Map types were not being returned when using the "simplify" option. The map type (M) was missing from the decode attributes function. The map type is an object, so it recurively simplifies the object and returns that.
Bug 2) Return all did not work if there was more than one page of data (which is the entire point of return all). Headers from the previous iteration were being passed causing an invalid signature error.

Fixes #4956 Fixes #4957

https://community.n8n.io/t/bug-with-dynamodb-connector-using-simplify-setting/20790/5

@CLAassistant
Copy link

CLAassistant commented Dec 19, 2022

CLA assistant check
All committers have signed the CLA.

@n8n-assistant n8n-assistant bot added community Authored by a community member node/improvement New feature or request labels Dec 19, 2022
…eing passed causing an invalid signature error
@napter napter changed the title Added 'M' type to decode attribute for dynamodb Fix bugs in dynamodb connector - Fixes #4956 #4957 Dec 19, 2022
@janober janober merged commit a43ea17 into n8n-io:master Dec 22, 2022
@janober janober added the Upcoming Release Will be part of the upcoming release label Dec 22, 2022
@janober
Copy link
Member

janober commented Dec 22, 2022

Got released with n8n@0.209.1

@janober janober removed the Upcoming Release Will be part of the upcoming release label Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Authored by a community member node/improvement New feature or request
Projects
None yet
3 participants