Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Fix displaying of some trigger nodes in the creator panel #5040

Merged

Conversation

OlegIvaniv
Copy link
Contributor

This PR fixes the bug caused by #4976 where trigger actions wouldn't display if they contained only single placeholder action.

Github issue / Community forum post (link here to close automatically): #4952

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Dec 27, 2022
@MiloradFilipovic MiloradFilipovic self-requested a review December 27, 2022 20:06
Copy link
Contributor

@MiloradFilipovic MiloradFilipovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected.

@OlegIvaniv OlegIvaniv merged commit 4daf905 into master Dec 28, 2022
@OlegIvaniv OlegIvaniv deleted the n8n-5932-rabbitmq-trigger-node-no-longer-shows-up branch December 28, 2022 08:21
@n8n-assistant n8n-assistant bot added the Upcoming Release Will be part of the upcoming release label Dec 28, 2022
MiloradFilipovic added a commit that referenced this pull request Dec 28, 2022
* master: (33 commits)
  ci: Update Jest setup on the CI to avoid OOM errors (no-changelog) (#5042)
  fix(editor): Fix displaying of some trigger nodes in the creator panel (#5040)
  fix(editor): Add sticky note without manual trigger (#5039)
  fix(editor): Display default missing value in table view as `undefined` (#5038)
  refactor(editor): Tweak phrasing of `itemMatching()` (no-changelog) (#5037)
  📚 Update CHANGELOG.md and main package.json to 0.209.3
  🔖 Release n8n@0.209.3
  ⬆️ Set n8n-core@0.149.2, n8n-editor-ui@0.175.3, n8n-nodes-base@0.207.2 and n8n-workflow@0.131.2 on n8n
  🔖 Release n8n-editor-ui@0.175.3
  ⬆️ Set n8n-design-system@0.49.3 and n8n-workflow@0.131.2 on n8n-editor-ui
  🔖 Release n8n-design-system@0.49.3
  🔖 Release n8n-nodes-base@0.207.2
  ⬆️ Set n8n-core@0.149.2 and n8n-workflow@0.131.2 on n8n-nodes-base
  🔖 Release n8n-node-dev@0.88.2
  ⬆️ Set n8n-core@0.149.2 and n8n-workflow@0.131.2 on n8n-node-dev
  🔖 Release n8n-core@0.149.2
  ⬆️ Set n8n-workflow@0.131.2 on n8n-core
  🔖 Release n8n-workflow@0.131.2
  fix(core): Non owner should be permitted to use their own credentials (#5036)
  fix(editor): Fix for loading executions that are not on the current executions list (#5035)
  ...
@janober
Copy link
Member

janober commented Dec 29, 2022

Got released with n8n@0.209.4

@janober janober removed the Upcoming Release Will be part of the upcoming release label Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants