fix(editor): Disable data pinning on multiple output node types #5111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivov
previously approved these changes
Jan 9, 2023
mutdmour
reviewed
Jan 9, 2023
packages/editor-ui/src/constants.ts
Outdated
| @@ -141,7 +142,11 @@ export const NON_ACTIVATABLE_TRIGGER_NODE_TYPES = [ | |||
| EXECUTE_WORKFLOW_TRIGGER_NODE_TYPE, | |||
| ]; | |||
|
|
|||
| export const MULTIPLE_OUTPUT_NODE_TYPES = [IF_NODE_TYPE, SWITCH_NODE_TYPE]; | |||
| export const MULTIPLE_OUTPUT_NODE_TYPES = [ | |||
There was a problem hiding this comment.
can we instead check if that node has multiple outputs? the outputs are specified as an array in the node properties.. can we check for that instead?
n8n-assistant
bot
added
n8n team
alexgrozav
changed the title
mutdmour
previously approved these changes
Jan 9, 2023
| ...MULTIPLE_OUTPUT_NODE_TYPES, | ||
| SPLIT_IN_BATCHES_NODE_TYPE, | ||
| ]; | ||
| export const PIN_DATA_NODE_TYPES_DENYLIST = [SPLIT_IN_BATCHES_NODE_TYPE]; |
There was a problem hiding this comment.
agree with @ivov that this can be a node property
packages/editor-ui/src/constants.ts
Outdated
| @@ -82,6 +82,7 @@ export const BAMBOO_HR_NODE_TYPE = 'n8n-nodes-base.bambooHr'; | |||
| export const CALENDLY_TRIGGER_NODE_TYPE = 'n8n-nodes-base.calendlyTrigger'; | |||
| export const CODE_NODE_TYPE = 'n8n-nodes-base.code'; | |||
| export const CRON_NODE_TYPE = 'n8n-nodes-base.cron'; | |||
| export const COMPARE_DATASETS_NODE_TYPE = 'n8n-nodes-base.compareDatasets'; | |||
There was a problem hiding this comment.
this can be deleted since it's not used
mutdmour
approved these changes
Jan 9, 2023
MiloradFilipovic
added a commit
that referenced
this pull request
Jan 10, 2023
* master: (21 commits) test: Fix default owner test to be able to reach setup page (#5113) refactor: Reduce custom docker image size by about 30% (#5104) fix(editor): Disable data pinning on multiple output node types (#5111) 📚 Update CHANGELOG.md and main package.json to 0.210.2 🔖 Release n8n@0.210.2 ⬆️ Set n8n-core@0.150.1, n8n-editor-ui@0.176.2, n8n-nodes-base@0.208.2 and n8n-workflow@0.132.1 on n8n 🔖 Release n8n-editor-ui@0.176.2 ⬆️ Set n8n-workflow@0.132.1 on n8n-editor-ui 🔖 Release n8n-nodes-base@0.208.2 ⬆️ Set n8n-core@0.150.1 and n8n-workflow@0.132.1 on n8n-nodes-base 🔖 Release n8n-node-dev@0.89.1 ⬆️ Set n8n-core@0.150.1 and n8n-workflow@0.132.1 on n8n-node-dev 🔖 Release n8n-core@0.150.1 ⬆️ Set n8n-workflow@0.132.1 on n8n-core 🔖 Release n8n-workflow@0.132.1 feat: Add source to all View Plans links (no-changelog) (#5097) fix: Do not attempt to save statistics data for unsaved workflows (#5106) fix: Update links for user management and SMTP help (#5109) fix(editor): Omit `pairedItem` from proxy completions (#5098) test: Fix e2e tests for inline expression editor (#5108) ...
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github issue / Community forum post (link here to close automatically):