fix: Extend date functions clobbering plus/minus #5170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
core
valya
changed the title
csuermann
reviewed
Jan 16, 2023
| function minus(date: Date | DateTime, extraArgs: unknown[]): Date { | ||
| function minus(date: Date | DateTime, extraArgs: unknown[]): Date | DateTime { | ||
| if (isDateTime(date) && extraArgs.length === 1) { | ||
| return date.plus(extraArgs[0] as DurationLike); |
There was a problem hiding this comment.
shouldn't that be 'minus'? 🤔
There was a problem hiding this comment.
You are correct. I guess that's what I get for trying to quickly push out a fix on a Monday morning with no coffee 🤦
krynble
reviewed
Jan 16, 2023
| @@ -161,7 +162,11 @@ function isWeekend(date: Date): boolean { | |||
| return [DAYS.saturday, DAYS.sunday].includes(DateTime.fromJSDate(date).weekday); | |||
| } | |||
|
|
|||
| function minus(date: Date | DateTime, extraArgs: unknown[]): Date { | |||
| function minus(date: Date | DateTime, extraArgs: unknown[]): Date | DateTime { | |||
There was a problem hiding this comment.
In order to remain consistent with the rest of the UI, shouldn't the functions always return primitives such as strings?
There was a problem hiding this comment.
We could but if things are strung together it's going to be a lot of checking if the string is a timestamp and converting it to a date, just to turn it back into a string.
krynble
approved these changes
Jan 16, 2023
n8n-assistant
bot
added
the
Upcoming Release
|
Got released with |
MiloradFilipovic
added a commit
that referenced
this pull request
Jan 17, 2023
* master: (21 commits) 📚 Update CHANGELOG.md and main package.json to 0.211.1 🔖 Release n8n@0.211.1 ⬆️ Set n8n-core@0.151.1, n8n-editor-ui@0.177.1, n8n-nodes-base@0.209.1 and n8n-workflow@0.133.1 on n8n 🔖 Release n8n-editor-ui@0.177.1 ⬆️ Set n8n-design-system@0.51.1 and n8n-workflow@0.133.1 on n8n-editor-ui 🔖 Release n8n-design-system@0.51.1 🔖 Release n8n-nodes-base@0.209.1 ⬆️ Set n8n-core@0.151.1 and n8n-workflow@0.133.1 on n8n-nodes-base 🔖 Release n8n-node-dev@0.90.1 ⬆️ Set n8n-core@0.151.1 and n8n-workflow@0.133.1 on n8n-node-dev 🔖 Release n8n-core@0.151.1 ⬆️ Set n8n-workflow@0.133.1 on n8n-core 🔖 Release n8n-workflow@0.133.1 fix: Extension deep compare not quite working for some primitives (#5172) feat(editor): Supress validation errors for freshly added nodes (#5149) test: Update unit tests to remove hash (#5152) feat(Google Ads Node): Update api version to v11 (#4427) fix: Extend date functions clobbering plus/minus (#5170) fix: Build `cli` to fix Postgres and MySQL test runs (#5171) feat(Google Drive Trigger Node): Use resource locator component (#5148) ... # Conflicts: # packages/editor-ui/src/components/NodeCredentials.vue # packages/editor-ui/src/components/ParameterInputList.vue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github issue / Community forum post (link here to close automatically):