feat(core): Fix populating of node custom api call options #5303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
core
ivov
requested changes
Jan 31, 2023
|
@ivov Thanks for reviewing and for all the helpful suggestions. I've addressed them and added the e2e test to check for the Custom API option and hint. Can you have another look, please? |
ivov
reviewed
Feb 2, 2023
netroy
reviewed
Feb 2, 2023
| if (!description.credentials) return false; | ||
|
|
||
| return description.credentials.some(({ name }) => { | ||
| const credType = this.credentialTypes[name].type; |
There was a problem hiding this comment.
This check here assumes that all credentials are loaded before the nodes. This is breaking custom nodes. Here is the fix.
There is also the issue of nodes only being aware of credentials that the loader they are a part of, which means that custom nodes can't use one of the officially shipped credentials.
OlegIvaniv
added a commit
that referenced
this pull request
Feb 2, 2023
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github issue / Community forum post (link here to close automatically): https://community.n8n.io/t/shopify-generic-api-call/22375