Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Upgrade mysql2 to address CVE-2024-21512 #9565

Merged
merged 1 commit into from
May 31, 2024

Conversation

netroy
Copy link
Member

@netroy netroy commented May 31, 2024

GH Advisory

Review / Merge checklist

  • PR title and summary are descriptive

Copy link
Contributor

@tomi tomi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels May 31, 2024
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Copy link

cypress bot commented May 31, 2024

2 flaky tests on run #5209 ↗︎

0 362 0 0 Flakiness 2

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 netroy 🗃️ e2e/*
Project: n8n Commit: 2d89d375d4
Status: Passed Duration: 04:43 💡
Started: May 31, 2024 9:42 AM Ended: May 31, 2024 9:46 AM
Flakiness  5-ndv.cy.ts • 1 flaky test

View Output Video

Test Artifacts
NDV > should not retrieve remote options when required params throw errors Screenshots Video
Flakiness  20-workflow-executions.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Current Workflow Executions > should auto load more items if there is space and auto scroll Test Replay Screenshots Video

Review all test suite changes for PR #9565 ↗︎

Copy link
Contributor

✅ All Cypress E2E specs passed

@netroy netroy merged commit 4b6e5f0 into master May 31, 2024
28 checks passed
@netroy netroy deleted the fix-CVE-2024-21512 branch May 31, 2024 09:54
@github-actions github-actions bot mentioned this pull request Jun 3, 2024
@janober
Copy link
Member

janober commented Jun 3, 2024

Got released with n8n@1.44.1

@github-actions github-actions bot mentioned this pull request Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants