fix(core): Start WaitTracker only in the main container #9600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
core
ivov
approved these changes
Jun 3, 2024
There was a problem hiding this comment.
WaitTracker initialization in the constructor means that as soon as this class enters the DI dependency tree, we start tracking for waiting executions
Thanks for this! Will keep an eye out for timers in constructors.
Tested with single main and with multi-main leader and follower and it works as expected.
|
✅ All Cypress E2E specs passed |
1 flaky test on run #5291 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| NDV > Stop listening for trigger event from NDV |
Screenshots
Video
|
|
Review all test suite changes for PR #9600 ↗︎
Merged
|
Got released with |
krynble
pushed a commit
that referenced
this pull request
Jun 7, 2024
ivov
added
the
release/backport
Merged
netroy
added a commit
that referenced
this pull request
Jun 11, 2024
We changed WaitTracker to not start the timer in the constructor in #9600. So we don't need to mock it anymore.
2 tasks
netroy
added a commit
that referenced
this pull request
Jun 12, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WaitTrackerinitialization in the constructor means that as soon as this class enters the DI dependency tree, we start tracking for waiting executions, causinggetWaitingExecutionsqueries to run even before theexecution_entitytable might be available.This can be verified by using any of the import commands on a new DB on any of the last releases.
Review / Merge checklist