fix(editor): Skip disabled nodes when detecting workflow issues #9610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MiloradFilipovic
changed the title
OlegIvaniv
previously approved these changes
Jun 4, 2024
n8n-assistant
bot
added
n8n team
|
|
2 flaky tests on run #5306 ↗︎
Details:
|
||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| NDV > should not retrieve remote options when required params throw errors |
Screenshots
Video
|
|
| NDV > Stop listening for trigger event from NDV |
Screenshots
Video
|
|
Review all test suite changes for PR #9610 ↗︎
OlegIvaniv
approved these changes
Jun 4, 2024
|
✅ All Cypress E2E specs passed |
Merged
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Not counting disabled nodes when detecting workflow errors. This should fix a bug where workflows cannot be activated after nodes with errors are disabled.
EDIT: Starting from this PR, the workflow settings e2e tests started failing. Reason is that we are getting the total workflow count by counting workflow cards. Unfortunately, the recycler component will not render cards outside of viewport so that is not giving us accurate count. I've changed it to use response from
/workflowsendpoint.Related tickets and issues
Fixes ADO-1658
Review / Merge checklist
(no-changelog)otherwise. (conventions)