fix(editor): Commit theme change from Save button #9619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For consistent UX, don't commit the selected theme until user clicks save. Otherwise the UI behaves differently depending which input elements are touched.
tomi
force-pushed
the
ado-1495-no-indication-of-editor-theme-setting-auto-saved
branch
from
6f4e6f7 to
e61c35f
Compare
n8n-assistant
bot
added
n8n team
|
✅ All Cypress E2E specs passed |
2 flaky tests on run #5311 ↗︎
Details:
|
|||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| NDV > should not retrieve remote options when required params throw errors |
Screenshots
Video
|
|
24-ndv-paired-item.cy.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| NDV > resolves expression with default item when input node is not parent, while still pairing items |
Test Replay
Screenshots
Video
|
|
Review all test suite changes for PR #9619 ↗︎
tomi
changed the title
tomi
deleted the
ado-1495-no-indication-of-editor-theme-setting-auto-saved
branch
Merged
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
For consistent UX, don't commit the selected theme until user
clicks save. Otherwise the UI behaves differently depending
which input elements are touched.
For next steps, we can sync the selected theme to the backend instead of storing it in the local storage.
Before:
Kapture.2024-06-04.at.16.14.34.mp4
After:
Kapture.2024-06-04.at.16.12.33.mp4
Related tickets and issues
https://linear.app/n8n/issue/ADO-1495/no-indication-of-editor-theme-setting-auto-saved
Review / Merge checklist
(no-changelog)otherwise. (conventions)