Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(AI Agent Node): Improve Tools agent empty tool input message #9622

Conversation

OlegIvaniv
Copy link
Contributor

Summary

  • Change order of Tools Agent to be on the first position
  • Wrap OpenAI error when tool input is empty and provide a more user-friendly message

Review / Merge checklist

  • PR title and summary are descriptive. Remember, the title automatically goes into the changelog. Use (no-changelog) otherwise. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.

    A bug is not considered fixed, unless a test is added to prevent it from happening again.
    A feature is not complete without tests.

Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
@n8n-assistant n8n-assistant bot added the n8n team Authored by the n8n team label Jun 4, 2024
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
Copy link

cypress bot commented Jun 5, 2024

2 flaky tests on run #5322 ↗︎

0 356 0 0 Flakiness 2

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 OlegIvaniv 🗃️ e2e/*
Project: n8n Commit: c59f126d0f
Status: Passed Duration: 04:53 💡
Started: Jun 5, 2024 11:48 AM Ended: Jun 5, 2024 11:53 AM
Flakiness  5-ndv.cy.ts • 1 flaky test

View Output Video

Test Artifacts
NDV > Stop listening for trigger event from NDV Screenshots Video
Flakiness  20-workflow-executions.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Current Workflow Executions > should auto load more items if there is space and auto scroll Test Replay Screenshots Video

Review all test suite changes for PR #9622 ↗︎

Copy link
Contributor

github-actions bot commented Jun 5, 2024

✅ All Cypress E2E specs passed

@OlegIvaniv OlegIvaniv merged commit e7f6162 into master Jun 5, 2024
28 checks passed
@OlegIvaniv OlegIvaniv deleted the ai-191-tools-agent-dont-error-when-there-are-no-tools-connected branch June 5, 2024 12:39
@github-actions github-actions bot mentioned this pull request Jun 5, 2024
@janober
Copy link
Member

janober commented Jun 5, 2024

Got released with n8n@1.45.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants