Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make AWS credential work with global AWS services #9631

Merged
merged 8 commits into from
Jun 5, 2024

Conversation

elsmr
Copy link
Member

@elsmr elsmr commented Jun 5, 2024

Summary

AWS credential was incorrectly setting region to amazonaws when there is no region in the URL.
For global AWS services this is the case, for example: iam.amazonaws.com.

Workflow to reproduce the issue can be found in Linear.

Related tickets and issues

https://linear.app/n8n/issue/NODE-1335/aws-credential-iam-region-issues

Review / Merge checklist

  • PR title and summary are descriptive. Remember, the title automatically goes into the changelog. Use (no-changelog) otherwise. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.

    A bug is not considered fixed, unless a test is added to prevent it from happening again.
    A feature is not complete without tests.

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team node/improvement New feature or request labels Jun 5, 2024
Copy link
Member

@netroy netroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the amount of checks this credential file has, I think we should start adding unit tests for it.

@elsmr elsmr requested a review from netroy June 5, 2024 12:25
@elsmr elsmr requested a review from netroy June 5, 2024 14:16
Copy link

cypress bot commented Jun 5, 2024

2 flaky tests on run #5326 ↗︎

0 356 0 0 Flakiness 2

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 elsmr 🗃️ e2e/*
Project: n8n Commit: f56d2b0d8b
Status: Passed Duration: 05:04 💡
Started: Jun 5, 2024 2:31 PM Ended: Jun 5, 2024 2:37 PM
Flakiness  cypress/e2e/5-ndv.cy.ts • 2 flaky tests

View Output Video

Test Artifacts
NDV > should not retrieve remote options when required params throw errors Screenshots Video
NDV > Stop listening for trigger event from NDV Screenshots Video

Review all test suite changes for PR #9631 ↗︎

Copy link
Contributor

github-actions bot commented Jun 5, 2024

✅ All Cypress E2E specs passed

@despairblue despairblue merged commit 9dbea73 into master Jun 5, 2024
28 checks passed
@despairblue despairblue deleted the node-1335-aws-credential-iam-region-issues branch June 5, 2024 14:53
@github-actions github-actions bot mentioned this pull request Jun 5, 2024
@janober
Copy link
Member

janober commented Jun 5, 2024

Got released with n8n@1.45.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team node/improvement New feature or request Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants