fix(X (Formerly Twitter) Node): Change how tweet id is retrieved from quote URL #9635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Joffcom
changed the title
n8n-assistant
bot
added
n8n team
netroy
requested changes
Jun 5, 2024
…-returnid-method-still-uses-twittercom
netroy
force-pushed
the
NODE-1386/x-twitter-returnid-method-still-uses-twittercom
branch
from
6316124 to
6d3ad7f
Compare
3 flaky tests on run #5330 ↗︎
Details:
|
||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| NDV > should not retrieve remote options when required params throw errors |
Screenshots
Video
|
|
| NDV > Stop listening for trigger event from NDV |
Screenshots
Video
|
|
24-ndv-paired-item.cy.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| NDV > resolves expression with default item when input node is not parent, while still pairing items |
Test Replay
Screenshots
Video
|
|
Review all test suite changes for PR #9635 ↗︎
|
✅ All Cypress E2E specs passed |
netroy
approved these changes
Jun 5, 2024
|
|
|
✅ All Cypress E2E specs passed |
riascho
deleted the
NODE-1386/x-twitter-returnid-method-still-uses-twittercom
branch
RicardoE105
pushed a commit
that referenced
this pull request
Jun 9, 2024
… quote URL (#9635) Co-authored-by: Jonathan Bennetts <jonathan.bennetts@gmail.com> Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
Merged
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
changed how we retrieve the tweet id from a url the user can paste into the
Quote a Tweetoptionby URL.previously this was done through regex but that broke when twitter.com re-branded to x.com
Related tickets and issues
Linear: https://linear.app/n8n/issue/NODE-1386/x-twitter-returnid-method-still-uses-twittercom
Forum: https://community.n8n.io/t/quote-tweet-not-working-in-x-formerly-twitter-node/47317
Review / Merge checklist
(no-changelog)otherwise. (conventions)