Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Reset pagination when output size changes #9652

Merged
merged 7 commits into from
Jun 6, 2024
Merged

fix: Reset pagination when output size changes #9652

merged 7 commits into from
Jun 6, 2024

Conversation

mutdmour
Copy link
Contributor

@mutdmour mutdmour commented Jun 6, 2024 •
edited
Loading

Summary

Reset pagination when output size changes.

[before]
You can see previous behavior here.
#9463

[after]
https://github.com/n8n-io/n8n/assets/4711238/e6b9a62b-0636-4835-9de4-ddffeeb241db

Related tickets and issues

#9463

Review / Merge checklist

  • PR title and summary are descriptive. Remember, the title automatically goes into the changelog. Use (no-changelog) otherwise. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.

    A bug is not considered fixed, unless a test is added to prevent it from happening again.
    A feature is not complete without tests.

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Jun 6, 2024
MiloradFilipovic
MiloradFilipovic approved these changes Jun 6, 2024
View reviewed changes
Copy link
Contributor

@MiloradFilipovic MiloradFilipovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Left a really minor comment but good to go

cypress/fixtures/NDV-debug-generate-data.json
{
"meta": {
"templateCredsSetupCompleted": true,
"instanceId": "5b397bc122efafc165b2a6e67d5e8d75b8138f0d24d6352fac713e4845b002a6"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: We don't need metadata in test fixtures

@cypress Cypress
Copy link

cypress bot commented Jun 6, 2024 •
edited
Loading

Passing run #5351 ↗︎

0 362 0 0 Flakiness 0

Details:

🌳 master 🖥️ browsers:node18.12.0-chrome107 🤖 PR User 🗃️ e2e/*
Project: n8n Commit: e520f8a98f
Status: Passed Duration: 04:50 💡
Started: Jun 7, 2024 3:11 AM Ended: Jun 7, 2024 3:16 AM

Review all test suite changes for PR #9652 ↗︎

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 6, 2024

✅ All Cypress E2E specs passed

@MiloradFilipovic MiloradFilipovic self-requested a review June 6, 2024 14:59
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 6, 2024

✅ All Cypress E2E specs passed

@mutdmour mutdmour merged commit e520f8a into master Jun 6, 2024
28 checks passed
@mutdmour mutdmour deleted the ado-2230 branch June 6, 2024 15:14
MiloradFilipovic added a commit that referenced this pull request Jun 7, 2024
@MiloradFilipovic
Merge branch 'master' into ADO-1920-tab-indent-in-expression-fields
1acdeae 
* master:
  feat(core): Add batching and other options to declarative nodes (#8885)
  fix: Reset pagination when output size changes (#9652)
RicardoE105 pushed a commit that referenced this pull request Jun 9, 2024
@mutdmour @RicardoE105
fix: Reset pagination when output size changes (#9652)
11e678d
@github-actions github-actions bot mentioned this pull request Jun 12, 2024
Merged
@janober
Copy link
Member

janober commented Jun 12, 2024

Got released with n8n@1.46.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiloradFilipovic MiloradFilipovic MiloradFilipovic approved these changes

Assignees
No one assigned
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mutdmour @janober @MiloradFilipovic