From 29ed5be13e55991543d44068348f8cecda934f33 Mon Sep 17 00:00:00 2001
From: Alex Grozav <alex@grozav.com>
Date: Wed, 21 Aug 2024 12:14:31 +0300
Subject: [PATCH 1/4] fix: stop telemetry from triggering when initializing
 workflow

---
 .../src/composables/useCanvasOperations.ts    | 20 +++++++++++++------
 1 file changed, 14 insertions(+), 6 deletions(-)

diff --git a/packages/editor-ui/src/composables/useCanvasOperations.ts b/packages/editor-ui/src/composables/useCanvasOperations.ts
index 11e40f39b356e..d537b7c21085d 100644
--- a/packages/editor-ui/src/composables/useCanvasOperations.ts
+++ b/packages/editor-ui/src/composables/useCanvasOperations.ts
@@ -105,6 +105,7 @@ type AddNodeOptions = {
 	openNDV?: boolean;
 	trackHistory?: boolean;
 	isAutoAdd?: boolean;
+	telemetry?: boolean;
 };
 
 export function useCanvasOperations({ router }: { router: ReturnType<typeof useRouter> }) {
@@ -434,6 +435,7 @@ export function useCanvasOperations({ router }: { router: ReturnType<typeof useR
 			trackHistory?: boolean;
 			trackBulk?: boolean;
 			keepPristine?: boolean;
+			telemetry?: boolean;
 		} = {},
 	) {
 		let insertPosition = options.position;
@@ -474,7 +476,6 @@ export function useCanvasOperations({ router }: { router: ReturnType<typeof useR
 						...options,
 						openNDV,
 						isAutoAdd,
-						trackHistory: options.trackHistory,
 					},
 				);
 			} catch (error) {
@@ -555,7 +556,13 @@ export function useCanvasOperations({ router }: { router: ReturnType<typeof useR
 				createConnectionToLastInteractedWithNode(nodeData, options);
 			}
 
-			runAddNodeHooks(nodeData, options);
+			if (options.telemetry !== false) {
+				trackAddNode(nodeData, options);
+			}
+
+			if (nodeData.type !== STICKY_NODE_TYPE) {
+				void externalHooks.run('nodeView.addNodeButton', { nodeTypeName: nodeData.type });
+			}
 
 			if (options.openNDV && !preventOpeningNDV) {
 				ndvStore.setActiveNodeName(nodeData.name);
@@ -652,13 +659,12 @@ export function useCanvasOperations({ router }: { router: ReturnType<typeof useR
 		}
 	}
 
-	function runAddNodeHooks(nodeData: INodeUi, options: AddNodeOptions) {
+	function trackAddNode(nodeData: INodeUi, options: AddNodeOptions) {
 		switch (nodeData.type) {
 			case STICKY_NODE_TYPE:
 				trackAddStickyNoteNode();
 				break;
 			default:
-				void externalHooks.run('nodeView.addNodeButton', { nodeTypeName: nodeData.type });
 				trackAddDefaultNode(nodeData, options);
 		}
 	}
@@ -1244,7 +1250,7 @@ export function useCanvasOperations({ router }: { router: ReturnType<typeof useR
 		workflowHelpers.initState(data);
 
 		// Add nodes and connections
-		await addNodes(data.nodes, { keepPristine: true });
+		await addNodes(data.nodes, { keepPristine: true, telemetry: false });
 		workflowsStore.setConnections(data.connections);
 	}
 
@@ -1412,7 +1418,9 @@ export function useCanvasOperations({ router }: { router: ReturnType<typeof useR
 		// Add the nodes with the changed node names, expressions and connections
 		historyStore.startRecordingUndo();
 
-		await addNodes(Object.values(tempWorkflow.nodes));
+		await addNodes(Object.values(tempWorkflow.nodes), {
+			telemetry: false,
+		});
 		addConnections(
 			mapLegacyConnectionsToCanvasConnections(
 				tempWorkflow.connectionsBySourceNode,

From d8af7fac3bda7ed3f422f2d28576d8bf6294b2ee Mon Sep 17 00:00:00 2001
From: Alex Grozav <alex@grozav.com>
Date: Wed, 21 Aug 2024 12:19:27 +0300
Subject: [PATCH 2/4] fix: only enable telemetry for node creator

---
 packages/editor-ui/src/composables/useCanvasOperations.ts | 2 +-
 packages/editor-ui/src/views/NodeView.v2.vue              | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/packages/editor-ui/src/composables/useCanvasOperations.ts b/packages/editor-ui/src/composables/useCanvasOperations.ts
index d537b7c21085d..7bba82d3a9c9c 100644
--- a/packages/editor-ui/src/composables/useCanvasOperations.ts
+++ b/packages/editor-ui/src/composables/useCanvasOperations.ts
@@ -556,7 +556,7 @@ export function useCanvasOperations({ router }: { router: ReturnType<typeof useR
 				createConnectionToLastInteractedWithNode(nodeData, options);
 			}
 
-			if (options.telemetry !== false) {
+			if (options.telemetry) {
 				trackAddNode(nodeData, options);
 			}
 
diff --git a/packages/editor-ui/src/views/NodeView.v2.vue b/packages/editor-ui/src/views/NodeView.v2.vue
index 3a8e2411cd985..996ec6f06234a 100644
--- a/packages/editor-ui/src/views/NodeView.v2.vue
+++ b/packages/editor-ui/src/views/NodeView.v2.vue
@@ -803,7 +803,7 @@ async function onAddNodesAndConnections(
 		return;
 	}
 
-	await addNodes(nodes, { dragAndDrop, position, trackHistory: true });
+	await addNodes(nodes, { dragAndDrop, position, trackHistory: true, telemetry: true });
 	await nextTick();
 
 	const offsetIndex = editableWorkflow.value.nodes.length - nodes.length;

From 3d41e8245cfc74924be25d569acff2c26d18a807 Mon Sep 17 00:00:00 2001
From: Alex Grozav <alex@grozav.com>
Date: Wed, 21 Aug 2024 12:26:22 +0300
Subject: [PATCH 3/4] fix: remove default value

---
 packages/editor-ui/src/composables/useCanvasOperations.ts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/packages/editor-ui/src/composables/useCanvasOperations.ts b/packages/editor-ui/src/composables/useCanvasOperations.ts
index 7bba82d3a9c9c..54434ed3dc568 100644
--- a/packages/editor-ui/src/composables/useCanvasOperations.ts
+++ b/packages/editor-ui/src/composables/useCanvasOperations.ts
@@ -1250,7 +1250,7 @@ export function useCanvasOperations({ router }: { router: ReturnType<typeof useR
 		workflowHelpers.initState(data);
 
 		// Add nodes and connections
-		await addNodes(data.nodes, { keepPristine: true, telemetry: false });
+		await addNodes(data.nodes, { keepPristine: true });
 		workflowsStore.setConnections(data.connections);
 	}
 

From a5e6bc0b75f76194c2f2290552a5998b0680a8b1 Mon Sep 17 00:00:00 2001
From: Alex Grozav <alex@grozav.com>
Date: Wed, 21 Aug 2024 12:27:05 +0300
Subject: [PATCH 4/4] fix: remove additional default value

---
 packages/editor-ui/src/composables/useCanvasOperations.ts | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/packages/editor-ui/src/composables/useCanvasOperations.ts b/packages/editor-ui/src/composables/useCanvasOperations.ts
index 54434ed3dc568..650fccbe9ac88 100644
--- a/packages/editor-ui/src/composables/useCanvasOperations.ts
+++ b/packages/editor-ui/src/composables/useCanvasOperations.ts
@@ -1418,9 +1418,7 @@ export function useCanvasOperations({ router }: { router: ReturnType<typeof useR
 		// Add the nodes with the changed node names, expressions and connections
 		historyStore.startRecordingUndo();
 
-		await addNodes(Object.values(tempWorkflow.nodes), {
-			telemetry: false,
-		});
+		await addNodes(Object.values(tempWorkflow.nodes));
 		addConnections(
 			mapLegacyConnectionsToCanvasConnections(
 				tempWorkflow.connectionsBySourceNode,