From 8345adbc41215c28f3a21b1ca94c6b78659896c8 Mon Sep 17 00:00:00 2001 From: Csaba Tuncsik Date: Thu, 14 Nov 2024 11:21:39 +0100 Subject: [PATCH 1/3] fix(editor): Change Home label to Overview --- packages/editor-ui/src/components/Projects/ProjectHeader.vue | 2 +- .../editor-ui/src/components/Projects/ProjectNavigation.vue | 2 +- packages/editor-ui/src/plugins/i18n/locales/en.json | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/editor-ui/src/components/Projects/ProjectHeader.vue b/packages/editor-ui/src/components/Projects/ProjectHeader.vue index a89a195975a08..6432bfcfcb0f2 100644 --- a/packages/editor-ui/src/components/Projects/ProjectHeader.vue +++ b/packages/editor-ui/src/components/Projects/ProjectHeader.vue @@ -23,7 +23,7 @@ const headerIcon = computed(() => { const projectName = computed(() => { if (!projectsStore.currentProject) { - return i18n.baseText('projects.menu.home'); + return i18n.baseText('projects.menu.overview'); } else if (projectsStore.currentProject.type === ProjectTypes.Personal) { return i18n.baseText('projects.menu.personal'); } else { diff --git a/packages/editor-ui/src/components/Projects/ProjectNavigation.vue b/packages/editor-ui/src/components/Projects/ProjectNavigation.vue index 47513ea1d6b64..fd9145bb99969 100644 --- a/packages/editor-ui/src/components/Projects/ProjectNavigation.vue +++ b/packages/editor-ui/src/components/Projects/ProjectNavigation.vue @@ -27,7 +27,7 @@ const isCreatingProject = ref(false); const isComponentMounted = ref(false); const home = computed(() => ({ id: 'home', - label: locale.baseText('projects.menu.home'), + label: locale.baseText('projects.menu.overview'), icon: 'home', route: { to: { name: VIEWS.HOMEPAGE }, diff --git a/packages/editor-ui/src/plugins/i18n/locales/en.json b/packages/editor-ui/src/plugins/i18n/locales/en.json index ca342147fcd4c..7e7c02315ada1 100644 --- a/packages/editor-ui/src/plugins/i18n/locales/en.json +++ b/packages/editor-ui/src/plugins/i18n/locales/en.json @@ -2499,7 +2499,7 @@ "settings.mfa.title": "Multi-factor Authentication", "settings.mfa.updateConfiguration": "MFA configuration updated", "settings.mfa.invalidAuthenticatorCode": "Invalid authenticator code", - "projects.menu.home": "Home", + "projects.menu.overview": "Overview", "projects.menu.title": "Projects", "projects.menu.personal": "Personal", "projects.menu.addProject": "Add project", From c7333c09373ebca78dd49b04b56d742e8f9ae9a4 Mon Sep 17 00:00:00 2001 From: Csaba Tuncsik Date: Thu, 14 Nov 2024 13:03:31 +0100 Subject: [PATCH 2/3] fix unit test --- .../editor-ui/src/components/Projects/ProjectHeader.test.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/editor-ui/src/components/Projects/ProjectHeader.test.ts b/packages/editor-ui/src/components/Projects/ProjectHeader.test.ts index 46b18718bb424..01c96a8ad8859 100644 --- a/packages/editor-ui/src/components/Projects/ProjectHeader.test.ts +++ b/packages/editor-ui/src/components/Projects/ProjectHeader.test.ts @@ -65,7 +65,7 @@ describe('ProjectHeader', () => { it('should render the correct title', async () => { const { getByText, rerender } = renderComponent(); - expect(getByText('Home')).toBeVisible(); + expect(getByText('Overview')).toBeVisible(); projectsStore.currentProject = { type: ProjectTypes.Personal } as Project; await rerender({}); From 2d1b4c2b319f0f39be3946040f3f7aef58315f48 Mon Sep 17 00:00:00 2001 From: Csaba Tuncsik Date: Thu, 14 Nov 2024 13:08:57 +0100 Subject: [PATCH 3/3] fix e2e test --- cypress/e2e/39-projects.cy.ts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/cypress/e2e/39-projects.cy.ts b/cypress/e2e/39-projects.cy.ts index 0d4154e646252..bbd0508662ae7 100644 --- a/cypress/e2e/39-projects.cy.ts +++ b/cypress/e2e/39-projects.cy.ts @@ -176,7 +176,7 @@ describe('Projects', { disableAutoLogin: true }, () => { let menuItems = cy.getByTestId('menu-item'); menuItems.filter('[class*=active_]').should('have.length', 1); - menuItems.filter(':contains("Home")[class*=active_]').should('exist'); + menuItems.filter(':contains("Overview")[class*=active_]').should('exist'); projects.getMenuItems().first().click(); @@ -222,7 +222,7 @@ describe('Projects', { disableAutoLogin: true }, () => { menuItems = cy.getByTestId('menu-item'); menuItems.filter('[class*=active_]').should('have.length', 1); - menuItems.filter(':contains("Home")[class*=active_]').should('exist'); + menuItems.filter(':contains("Overview")[class*=active_]').should('exist'); workflowsPage.getters.workflowCards().should('have.length', 2).first().click(); @@ -230,7 +230,7 @@ describe('Projects', { disableAutoLogin: true }, () => { cy.getByTestId('execute-workflow-button').should('be.visible'); menuItems = cy.getByTestId('menu-item'); - menuItems.filter(':contains("Home")[class*=active_]').should('not.exist'); + menuItems.filter(':contains("Overview")[class*=active_]').should('not.exist'); menuItems = cy.getByTestId('menu-item'); menuItems.filter('[class*=active_]').should('have.length', 1);