From 0c2d7a949bf654924f9750d7e90e13af3ad2cc68 Mon Sep 17 00:00:00 2001
From: Michael Kret <michael.k@radency.com>
Date: Wed, 22 May 2024 11:36:55 +0300
Subject: [PATCH 1/7] test button tolltip on latest node version

---
 .../src/components/NodeDetailsView.vue        | 14 +++++++++++
 .../src/components/NodeExecuteButton.vue      | 24 +++++++++++++++----
 .../editor-ui/src/components/NodeSettings.vue | 13 ++++++++++
 .../src/plugins/i18n/locales/en.json          |  1 +
 4 files changed, 48 insertions(+), 4 deletions(-)

diff --git a/packages/editor-ui/src/components/NodeDetailsView.vue b/packages/editor-ui/src/components/NodeDetailsView.vue
index 7822f32dc9916..662c54f595a55 100644
--- a/packages/editor-ui/src/components/NodeDetailsView.vue
+++ b/packages/editor-ui/src/components/NodeDetailsView.vue
@@ -113,6 +113,7 @@
 						:read-only="readOnly"
 						:block-u-i="blockUi && showTriggerPanel"
 						:executable="!readOnly"
+						:input-size="inputSize"
 						@value-changed="valueChanged"
 						@execute="onNodeExecute"
 						@stop-execution="onStopExecution"
@@ -312,6 +313,18 @@ export default defineComponent({
 			return null;
 		});
 
+		const inputSize = computed(() => {
+			if (workflowRunData.value && inputNodeName.value) {
+				return (
+					workflowRunData.value[inputNodeName.value]?.[inputRun.value]?.data?.[
+						NodeConnectionType.Main
+					]?.[outputRun.value]?.length ?? 0
+				);
+			}
+
+			return 0;
+		});
+
 		const isTriggerNode = computed(
 			() =>
 				!!activeNodeType.value &&
@@ -847,6 +860,7 @@ export default defineComponent({
 			inputRun,
 			linked,
 			inputNodeName,
+			inputSize,
 			hasForeignCredential,
 			outputRun,
 			isOutputPaneActive,
diff --git a/packages/editor-ui/src/components/NodeExecuteButton.vue b/packages/editor-ui/src/components/NodeExecuteButton.vue
index 917a46b207f9b..10adaaf74be58 100644
--- a/packages/editor-ui/src/components/NodeExecuteButton.vue
+++ b/packages/editor-ui/src/components/NodeExecuteButton.vue
@@ -1,20 +1,24 @@
 <template>
 	<div>
-		<n8n-tooltip placement="bottom" :disabled="!disabledHint">
+		<n8n-tooltip placement="right" :disabled="!tooltipText">
 			<template #content>
-				<div>{{ disabledHint }}</div>
+				<div>{{ tooltipText }}</div>
 			</template>
 			<div>
 				<n8n-button
 					v-bind="$attrs"
-					:loading="nodeRunning && !isListeningForEvents && !isListeningForWorkflowEvents"
+					:loading
 					:disabled="disabled || !!disabledHint"
 					:label="buttonLabel"
 					:type="type"
 					:size="size"
 					:icon="!isListeningForEvents && !hideIcon ? 'flask' : undefined"
 					:transparent-background="transparent"
-					:title="!isTriggerNode ? $locale.baseText('ndv.execute.testNode.description') : ''"
+					:title="
+						!isTriggerNode && !tooltipText
+							? $locale.baseText('ndv.execute.testNode.description')
+							: ''
+					"
 					@click="onClick"
 				/>
 			</div>
@@ -76,6 +80,9 @@ export default defineComponent({
 		hideIcon: {
 			type: Boolean,
 		},
+		tooltip: {
+			type: String,
+		},
 	},
 	emits: ['stopExecution', 'execute'],
 	setup(props) {
@@ -193,6 +200,11 @@ export default defineComponent({
 
 			return '';
 		},
+		tooltipText(): string {
+			if (this.disabledHint) return this.disabledHint;
+			if (this.tooltip && !this.loading) return this.tooltip;
+			return '';
+		},
 		buttonLabel(): string {
 			if (this.isListeningForEvents || this.isListeningForWorkflowEvents) {
 				return this.$locale.baseText('ndv.execute.stopListening');
@@ -220,6 +232,10 @@ export default defineComponent({
 
 			return this.$locale.baseText('ndv.execute.testNode');
 		},
+
+		loading(): boolean {
+			return this.nodeRunning && !this.isListeningForEvents && !this.isListeningForWorkflowEvents;
+		},
 	},
 	methods: {
 		async stopWaitingForWebhook() {
diff --git a/packages/editor-ui/src/components/NodeSettings.vue b/packages/editor-ui/src/components/NodeSettings.vue
index 06cc232faf828..493272fc657d2 100644
--- a/packages/editor-ui/src/components/NodeSettings.vue
+++ b/packages/editor-ui/src/components/NodeSettings.vue
@@ -22,6 +22,7 @@
 						data-test-id="node-execute-button"
 						:node-name="node.name"
 						:disabled="outputPanelEditMode.enabled && !isTriggerNode"
+						:tooltip="executeButtonTooltip"
 						size="small"
 						telemetry-source="parameters"
 						@execute="onNodeExecute"
@@ -307,6 +308,14 @@ export default defineComponent({
 		isLatestNodeVersion(): boolean {
 			return !this.node?.typeVersion || this.latestVersion === this.node.typeVersion;
 		},
+		executeButtonTooltip(): string {
+			if (this.isLatestNodeVersion && this.inputSize > 1) {
+				return this.$locale.baseText('nodeSettings.executeButtonTooltip.times', {
+					interpolate: { inputSize: this.inputSize },
+				});
+			}
+			return '';
+		},
 		nodeVersionTag(): string {
 			if (!this.nodeType || this.nodeType.hidden) {
 				return this.$locale.baseText('nodeSettings.deprecated');
@@ -422,6 +431,10 @@ export default defineComponent({
 			type: Boolean,
 			default: true,
 		},
+		inputSize: {
+			type: Number,
+			default: 0,
+		},
 	},
 	data() {
 		return {
diff --git a/packages/editor-ui/src/plugins/i18n/locales/en.json b/packages/editor-ui/src/plugins/i18n/locales/en.json
index 9153d85de699f..570bc04714340 100644
--- a/packages/editor-ui/src/plugins/i18n/locales/en.json
+++ b/packages/editor-ui/src/plugins/i18n/locales/en.json
@@ -1111,6 +1111,7 @@
 	"nodeSettings.onError.options.stopWorkflow.description": "Halt execution and fail workflow",
 	"nodeSettings.onError.options.stopWorkflow.displayName": "Stop Workflow",
 	"nodeSettings.docs": "Docs",
+	"nodeSettings.executeButtonTooltip.times": "Will execute {inputSize} times, once for each input item",
 	"nodeSettings.executeOnce.description": "If active, the node executes only once, with data from the first item it receives",
 	"nodeSettings.executeOnce.displayName": "Execute Once",
 	"nodeSettings.maxTries.description": "Number of times to attempt to execute the node before failing the execution",

From a98e4c2370f21f814e9a18128942238d993d0762 Mon Sep 17 00:00:00 2001
From: Michael Kret <michael.k@radency.com>
Date: Wed, 22 May 2024 13:16:52 +0300
Subject: [PATCH 2/7] run once exceptions

---
 .../editor-ui/src/components/NodeSettings.vue |  7 +++++-
 packages/workflow/src/NodeHelpers.ts          | 23 +++++++++++++++++++
 2 files changed, 29 insertions(+), 1 deletion(-)

diff --git a/packages/editor-ui/src/components/NodeSettings.vue b/packages/editor-ui/src/components/NodeSettings.vue
index 493272fc657d2..4326cd91408e6 100644
--- a/packages/editor-ui/src/components/NodeSettings.vue
+++ b/packages/editor-ui/src/components/NodeSettings.vue
@@ -309,7 +309,12 @@ export default defineComponent({
 			return !this.node?.typeVersion || this.latestVersion === this.node.typeVersion;
 		},
 		executeButtonTooltip(): string {
-			if (this.isLatestNodeVersion && this.inputSize > 1) {
+			if (
+				this.node &&
+				this.isLatestNodeVersion &&
+				this.inputSize > 1 &&
+				!NodeHelpers.willExecutesOnce(this.node.type, this.node.parameters)
+			) {
 				return this.$locale.baseText('nodeSettings.executeButtonTooltip.times', {
 					interpolate: { inputSize: this.inputSize },
 				});
diff --git a/packages/workflow/src/NodeHelpers.ts b/packages/workflow/src/NodeHelpers.ts
index 8149022d8834e..af83d8f0996d2 100644
--- a/packages/workflow/src/NodeHelpers.ts
+++ b/packages/workflow/src/NodeHelpers.ts
@@ -1722,3 +1722,26 @@ export function getCredentialsForNode(
 
 	return object.description.credentials ?? [];
 }
+
+export function willExecutesOnce(type: string, parameters: INodeParameters): boolean {
+	//nodes that would execute only once with such parameters
+	const NODES_EXECUTES_ONCE: { [key: string]: { [key: string]: NodeParameterValue[] } } = {
+		'n8n-nodes-base.code': {
+			mode: [undefined, 'runOnceForAllItems'],
+		},
+	};
+
+	if (NODES_EXECUTES_ONCE[type]) {
+		for (const parameter of Object.keys(NODES_EXECUTES_ONCE[type])) {
+			if (
+				!NODES_EXECUTES_ONCE[type][parameter].includes(parameters[parameter] as NodeParameterValue)
+			) {
+				return false;
+			}
+		}
+
+		return true;
+	}
+
+	return false;
+}

From d9f6ba237f0776e2f74e74480e1348fe3f283b9c Mon Sep 17 00:00:00 2001
From: Michael Kret <michael.k@radency.com>
Date: Wed, 22 May 2024 16:54:39 +0300
Subject: [PATCH 3/7] show popup only 10 times for user

---
 .../src/components/NodeExecuteButton.vue      | 19 ++++++++++++++++++-
 1 file changed, 18 insertions(+), 1 deletion(-)

diff --git a/packages/editor-ui/src/components/NodeExecuteButton.vue b/packages/editor-ui/src/components/NodeExecuteButton.vue
index 10adaaf74be58..b6694859aaf33 100644
--- a/packages/editor-ui/src/components/NodeExecuteButton.vue
+++ b/packages/editor-ui/src/components/NodeExecuteButton.vue
@@ -19,6 +19,7 @@
 							? $locale.baseText('ndv.execute.testNode.description')
 							: ''
 					"
+					@mouseover="onMouseOver"
 					@click="onClick"
 				/>
 			</div>
@@ -50,6 +51,9 @@ import { useRunWorkflow } from '@/composables/useRunWorkflow';
 import { useUIStore } from '@/stores/ui.store';
 import { useRouter } from 'vue-router';
 
+const NODE_TEST_STEP_POPUP_COUNT_KEY = 'N8N_NODE_TEST_STEP_POPUP_COUNT';
+const MAX_POPUP_COUNT = 10;
+
 export default defineComponent({
 	inheritAttrs: false,
 	props: {
@@ -202,7 +206,8 @@ export default defineComponent({
 		},
 		tooltipText(): string {
 			if (this.disabledHint) return this.disabledHint;
-			if (this.tooltip && !this.loading) return this.tooltip;
+			if (this.tooltip && !this.loading && this.testStepButtonPopupCount() < MAX_POPUP_COUNT)
+				return this.tooltip;
 			return '';
 		},
 		buttonLabel(): string {
@@ -247,6 +252,18 @@ export default defineComponent({
 			}
 		},
 
+		testStepButtonPopupCount() {
+			return Number(localStorage.getItem(NODE_TEST_STEP_POPUP_COUNT_KEY));
+		},
+
+		onMouseOver() {
+			const count = this.testStepButtonPopupCount();
+
+			if (count < MAX_POPUP_COUNT) {
+				localStorage.setItem(NODE_TEST_STEP_POPUP_COUNT_KEY, `${count + 1}`);
+			}
+		},
+
 		async onClick() {
 			// Show chat if it's a chat node or a child of a chat node with no input data
 			if (this.isChatNode || (this.isChatChild && this.ndvStore.isNDVDataEmpty('input'))) {

From b4bcf0e66476e064c353f6ba1d8444da9462b027 Mon Sep 17 00:00:00 2001
From: Michael Kret <michael.k@radency.com>
Date: Thu, 23 May 2024 09:33:49 +0300
Subject: [PATCH 4/7] clean up, delay to update popup count

---
 .../src/components/NodeExecuteButton.vue       | 10 ++++++++--
 .../editor-ui/src/components/NodeSettings.vue  |  2 +-
 packages/workflow/src/Constants.ts             | 13 +++++++++++++
 packages/workflow/src/NodeHelpers.ts           | 18 ++++++------------
 4 files changed, 28 insertions(+), 15 deletions(-)

diff --git a/packages/editor-ui/src/components/NodeExecuteButton.vue b/packages/editor-ui/src/components/NodeExecuteButton.vue
index b6694859aaf33..234309fca4d4b 100644
--- a/packages/editor-ui/src/components/NodeExecuteButton.vue
+++ b/packages/editor-ui/src/components/NodeExecuteButton.vue
@@ -53,6 +53,7 @@ import { useRouter } from 'vue-router';
 
 const NODE_TEST_STEP_POPUP_COUNT_KEY = 'N8N_NODE_TEST_STEP_POPUP_COUNT';
 const MAX_POPUP_COUNT = 10;
+const POPUP_UPDATE_DELAY = 3000;
 
 export default defineComponent({
 	inheritAttrs: false,
@@ -102,6 +103,7 @@ export default defineComponent({
 			pinnedData,
 			runWorkflow,
 			stopCurrentExecution,
+			lastPopupCountUpdate: 0,
 			...useToast(),
 			...useMessage(),
 		};
@@ -259,8 +261,12 @@ export default defineComponent({
 		onMouseOver() {
 			const count = this.testStepButtonPopupCount();
 
-			if (count < MAX_POPUP_COUNT) {
-				localStorage.setItem(NODE_TEST_STEP_POPUP_COUNT_KEY, `${count + 1}`);
+			if (count < MAX_POPUP_COUNT && !this.disabledHint && this.tooltipText) {
+				const now = Date.now();
+				if (!this.lastPopupCountUpdate || now - this.lastPopupCountUpdate >= POPUP_UPDATE_DELAY) {
+					localStorage.setItem(NODE_TEST_STEP_POPUP_COUNT_KEY, `${count + 1}`);
+					this.lastPopupCountUpdate = now;
+				}
 			}
 		},
 
diff --git a/packages/editor-ui/src/components/NodeSettings.vue b/packages/editor-ui/src/components/NodeSettings.vue
index 4326cd91408e6..cd74caa5e9016 100644
--- a/packages/editor-ui/src/components/NodeSettings.vue
+++ b/packages/editor-ui/src/components/NodeSettings.vue
@@ -313,7 +313,7 @@ export default defineComponent({
 				this.node &&
 				this.isLatestNodeVersion &&
 				this.inputSize > 1 &&
-				!NodeHelpers.willExecutesOnce(this.node.type, this.node.parameters)
+				!NodeHelpers.isSingleExecution(this.node.type, this.node.parameters)
 			) {
 				return this.$locale.baseText('nodeSettings.executeButtonTooltip.times', {
 					interpolate: { inputSize: this.inputSize },
diff --git a/packages/workflow/src/Constants.ts b/packages/workflow/src/Constants.ts
index 1988f655d8155..d6c25916fb04b 100644
--- a/packages/workflow/src/Constants.ts
+++ b/packages/workflow/src/Constants.ts
@@ -1,3 +1,5 @@
+import type { NodeParameterValue } from './Interfaces';
+
 export const BINARY_ENCODING = 'base64';
 export const WAIT_TIME_UNLIMITED = '3000-01-01T00:00:00.000Z';
 
@@ -62,3 +64,14 @@ export const LANGCHAIN_CUSTOM_TOOLS = [
 	CODE_TOOL_LANGCHAIN_NODE_TYPE,
 	WORKFLOW_TOOL_LANGCHAIN_NODE_TYPE,
 ];
+
+//nodes that would execute only once with such parameters
+//add 'undefined' to parameters values if it is parameter's default value
+export const SINGLE_EXECUTION_NODES: { [key: string]: { [key: string]: NodeParameterValue[] } } = {
+	'n8n-nodes-base.code': {
+		mode: [undefined, 'runOnceForAllItems'],
+	},
+	'n8n-nodes-base.executeWorkflow': {
+		mode: [undefined, 'once'],
+	},
+};
diff --git a/packages/workflow/src/NodeHelpers.ts b/packages/workflow/src/NodeHelpers.ts
index a618bb866913f..3f41fb776aa3b 100644
--- a/packages/workflow/src/NodeHelpers.ts
+++ b/packages/workflow/src/NodeHelpers.ts
@@ -56,6 +56,7 @@ import type { Workflow } from './Workflow';
 import { validateFilterParameter } from './NodeParameters/FilterParameter';
 import { validateFieldType } from './TypeValidation';
 import { ApplicationError } from './errors/application.error';
+import { SINGLE_EXECUTION_NODES } from './Constants';
 
 export const cronNodeOptions: INodePropertyCollection[] = [
 	{
@@ -1749,19 +1750,12 @@ export function getCredentialsForNode(
 	return object.description.credentials ?? [];
 }
 
-export function willExecutesOnce(type: string, parameters: INodeParameters): boolean {
-	//nodes that would execute only once with such parameters
-	const NODES_EXECUTES_ONCE: { [key: string]: { [key: string]: NodeParameterValue[] } } = {
-		'n8n-nodes-base.code': {
-			mode: [undefined, 'runOnceForAllItems'],
-		},
-	};
+export function isSingleExecution(type: string, parameters: INodeParameters): boolean {
+	const singleExecutionCase = SINGLE_EXECUTION_NODES[type];
 
-	if (NODES_EXECUTES_ONCE[type]) {
-		for (const parameter of Object.keys(NODES_EXECUTES_ONCE[type])) {
-			if (
-				!NODES_EXECUTES_ONCE[type][parameter].includes(parameters[parameter] as NodeParameterValue)
-			) {
+	if (singleExecutionCase) {
+		for (const parameter of Object.keys(singleExecutionCase)) {
+			if (!singleExecutionCase[parameter].includes(parameters[parameter] as NodeParameterValue)) {
 				return false;
 			}
 		}

From dbd1b246a041e950a7960aadecf449d7a34fd144 Mon Sep 17 00:00:00 2001
From: Michael Kret <michael.k@radency.com>
Date: Tue, 28 May 2024 10:18:29 +0300
Subject: [PATCH 5/7] more entries to SINGLE_EXECUTION_NODES

---
 packages/workflow/src/Constants.ts | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/packages/workflow/src/Constants.ts b/packages/workflow/src/Constants.ts
index d6c25916fb04b..8a7494980cae6 100644
--- a/packages/workflow/src/Constants.ts
+++ b/packages/workflow/src/Constants.ts
@@ -74,4 +74,22 @@ export const SINGLE_EXECUTION_NODES: { [key: string]: { [key: string]: NodeParam
 	'n8n-nodes-base.executeWorkflow': {
 		mode: [undefined, 'once'],
 	},
+	'n8n-nodes-base.crateDb': {
+		operation: [undefined, 'update'], // default insert
+	},
+	'n8n-nodes-base.timescaleDb': {
+		operation: [undefined, 'update'], // default insert
+	},
+	'n8n-nodes-base.microsoftSql': {
+		operation: [undefined, 'update', 'delete'], // default insert
+	},
+	'n8n-nodes-base.questDb': {
+		operation: [undefined], // default insert
+	},
+	'n8n-nodes-base.mongoDb': {
+		operation: ['insert', 'update'],
+	},
+	'n8n-nodes-base.redis': {
+		operation: [undefined], // default info
+	},
 };

From 4be86b411ac9a9957773350bf80c69a61ea226d0 Mon Sep 17 00:00:00 2001
From: Michael Kret <88898367+michael-radency@users.noreply.github.com>
Date: Mon, 3 Jun 2024 12:55:02 +0300
Subject: [PATCH 6/7] Update
 packages/editor-ui/src/components/NodeDetailsView.vue

Co-authored-by: Elias Meire <elias@meire.dev>
---
 .../editor-ui/src/components/NodeDetailsView.vue     | 12 +-----------
 1 file changed, 1 insertion(+), 11 deletions(-)

diff --git a/packages/editor-ui/src/components/NodeDetailsView.vue b/packages/editor-ui/src/components/NodeDetailsView.vue
index 662c54f595a55..2dfe39ad4cb90 100644
--- a/packages/editor-ui/src/components/NodeDetailsView.vue
+++ b/packages/editor-ui/src/components/NodeDetailsView.vue
@@ -313,17 +313,7 @@ export default defineComponent({
 			return null;
 		});
 
-		const inputSize = computed(() => {
-			if (workflowRunData.value && inputNodeName.value) {
-				return (
-					workflowRunData.value[inputNodeName.value]?.[inputRun.value]?.data?.[
-						NodeConnectionType.Main
-					]?.[outputRun.value]?.length ?? 0
-				);
-			}
-
-			return 0;
-		});
+		const inputSize = computed(() => ndvStore.ndvInputDataWithPinnedData.length);
 
 		const isTriggerNode = computed(
 			() =>

From 45fb28dbed9bb6e52ac709f9bca619daf3048f03 Mon Sep 17 00:00:00 2001
From: Michael Kret <michael.k@radency.com>
Date: Mon, 3 Jun 2024 15:20:44 +0300
Subject: [PATCH 7/7] tests

---
 packages/workflow/test/NodeHelpers.test.ts | 29 +++++++++++++++++++++-
 1 file changed, 28 insertions(+), 1 deletion(-)

diff --git a/packages/workflow/test/NodeHelpers.test.ts b/packages/workflow/test/NodeHelpers.test.ts
index 6a7e70e2e5572..820a7321bcebd 100644
--- a/packages/workflow/test/NodeHelpers.test.ts
+++ b/packages/workflow/test/NodeHelpers.test.ts
@@ -1,7 +1,7 @@
 import type { INode, INodeParameters, INodeProperties, INodeTypeDescription } from '@/Interfaces';
 import type { Workflow } from '../src';
 
-import { getNodeParameters, getNodeHints } from '@/NodeHelpers';
+import { getNodeParameters, getNodeHints, isSingleExecution } from '@/NodeHelpers';
 
 describe('NodeHelpers', () => {
 	describe('getNodeParameters', () => {
@@ -3528,4 +3528,31 @@ describe('NodeHelpers', () => {
 			expect(hints).toHaveLength(1);
 		});
 	});
+	describe('isSingleExecution', () => {
+		test('should determine based on node parameters if it would be executed once', () => {
+			expect(isSingleExecution('n8n-nodes-base.code', {})).toEqual(true);
+			expect(isSingleExecution('n8n-nodes-base.code', { mode: 'runOnceForEachItem' })).toEqual(
+				false,
+			);
+			expect(isSingleExecution('n8n-nodes-base.executeWorkflow', {})).toEqual(true);
+			expect(isSingleExecution('n8n-nodes-base.executeWorkflow', { mode: 'each' })).toEqual(false);
+			expect(isSingleExecution('n8n-nodes-base.crateDb', {})).toEqual(true);
+			expect(isSingleExecution('n8n-nodes-base.crateDb', { operation: 'update' })).toEqual(true);
+			expect(isSingleExecution('n8n-nodes-base.timescaleDb', {})).toEqual(true);
+			expect(isSingleExecution('n8n-nodes-base.timescaleDb', { operation: 'update' })).toEqual(
+				true,
+			);
+			expect(isSingleExecution('n8n-nodes-base.microsoftSql', {})).toEqual(true);
+			expect(isSingleExecution('n8n-nodes-base.microsoftSql', { operation: 'update' })).toEqual(
+				true,
+			);
+			expect(isSingleExecution('n8n-nodes-base.microsoftSql', { operation: 'delete' })).toEqual(
+				true,
+			);
+			expect(isSingleExecution('n8n-nodes-base.questDb', {})).toEqual(true);
+			expect(isSingleExecution('n8n-nodes-base.mongoDb', { operation: 'insert' })).toEqual(true);
+			expect(isSingleExecution('n8n-nodes-base.mongoDb', { operation: 'update' })).toEqual(true);
+			expect(isSingleExecution('n8n-nodes-base.redis', {})).toEqual(true);
+		});
+	});
 });