Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Large Png's are not fully written to the file sometimes. #148

Open
startswithaj opened this issue May 4, 2023 · 3 comments
Open

Large Png's are not fully written to the file sometimes. #148

startswithaj opened this issue May 4, 2023 · 3 comments

Comments

@startswithaj
Copy link

startswithaj commented May 4, 2023

Thanks for producing this @naddison36

When I generate a large diagram and output to a png. It seems like the whole image is not getting written to the file. Ends up with a partial image. It's intermittent, it doesn't always happen. Seems like it could be a race condition between the file being written and the program exiting. Maybe the file write isn't being awaited?
Screenshot 2023-05-04 at 4 05 36 pm

@naddison36
Copy link
Owner

Thanks for reporting. Is there an example contract this sometimes happens for?

@startswithaj
Copy link
Author

hey @naddison36 its a private repo that I'm working on. I can have a look for a public repo thats big and try and repro.

@startswithaj
Copy link
Author

Had a quick look at the code that writes the file. Looks tight. It could be the fault of convert-svg-to-png

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants