Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Magic configurable #30

Open
JeremyRand opened this issue Oct 11, 2020 · 2 comments
Open

Make Magic configurable #30

JeremyRand opened this issue Oct 11, 2020 · 2 comments

Comments

@JeremyRand
Copy link
Member

We should make the Magic Value+Data configurable instead of hardcoding it to Namecoin=1. We should also support multiple Magics (shouldn't be hard once we switch from cflag to an easyconfig struct). We should also add an integration test that makes sure that the Magic doesn't interfere with certutil deleting the cert. (I just checked in a Windows 10 VM and it indeed doesn't interfere; deleting the cert with certutil results in the entire cert key being removed, including the Magic.)
@JeremyRand
Copy link
Member Author

Partially implemented in #62 (supports non-hardcoded Value+Data, but doesn't support multiple Magics, and doesn't do an integration test with certutil).

@JeremyRand
Copy link
Member Author

Blocked by #43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JeremyRand