Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra patches for Electrum-NMC stable branches #164

Open
JeremyRand opened this issue Aug 23, 2019 · 18 comments
Open

Extra patches for Electrum-NMC stable branches #164

JeremyRand opened this issue Aug 23, 2019 · 18 comments

Comments

@JeremyRand
Copy link
Member

Some concerns have been raised by one of our funding sources about the slow progress getting patches merged to upstream Electrum. Due to this, Electrum-NMC's stable branches will begin carrying extra patches that have been submitted upstream but not yet merged upstream. The unstable bitcoin/auxpow/master branches will not carry those patches, in order to minimize merge conflicts when the patches eventually get merged upstream. This issue will track which patches are being carried in our stable branches, and link to the corresponding upstream PR's.

@JeremyRand
Copy link
Member Author

Status on relevant patches:

@JeremyRand
Copy link
Member Author

Updated status on relevant patches:

@JeremyRand
Copy link
Member Author

@domob1812 Will adding these patches to Electrum-NMC stable branches cause any disruption to Xaya?

@domob1812
Copy link

@JeremyRand: I've not looked at them, but in general you should not be concerned about that. Electrum-NMC should do what is best for Namecoin, and I will worry about how that relates to Xaya.

@domob1812
Copy link

FYI, I've now looked at the patches in a bit more detail. The only one that is relevant for Xaya is spesmilo#5147. Xaya has continuous difficulty retargeting, and because of that needs a lot more information in checkpoints in order to be able to compute the following difficulty. But since your patch essentially simplifies checkpoint handling, it will probably also simplify Xaya's changes. Hence it will probably require some work on my side after merging, but will then probably make life easier in the long term.

@JeremyRand
Copy link
Member Author

Updated status on relevant patches:

@JeremyRand
Copy link
Member Author

Updated status on relevant patches:

@JeremyRand
Copy link
Member Author

spesmilo#5537 is merged upstream, so is being removed from this list.

Updated status on relevant patches:

@JeremyRand
Copy link
Member Author

Updated status on relevant patches:

@JeremyRand
Copy link
Member Author

spesmilo#5432 is merged upstream, so is being removed from this list.

@JeremyRand
Copy link
Member Author

Updated status on relevant patches:

@JeremyRand
Copy link
Member Author

Updated status on relevant patches:

@JeremyRand
Copy link
Member Author

@JeremyRand
Copy link
Member Author

Updated status on relevant patches:

@JeremyRand
Copy link
Member Author

Updated status on relevant patches:

@JeremyRand
Copy link
Member Author

Updated status on relevant patches:

@JeremyRand
Copy link
Member Author

Updated status on relevant patches:

@JeremyRand
Copy link
Member Author

Updated status on relevant patches:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants