Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuilding GTK2 assets shows missing elements in assets.svg. #50

Closed
jayarc opened this issue Jul 11, 2016 · 6 comments
Closed

Rebuilding GTK2 assets shows missing elements in assets.svg. #50

jayarc opened this issue Jul 11, 2016 · 6 comments

Comments

@jayarc
Copy link

jayarc commented Jul 11, 2016

If I clone the repo and leave the static assets how they are initially, things look ok. When I go and make a change and run ./render-bits to update the assets from assets.svg I get the following errors because the assets.txt is looking for some IDs in the assets.svg that you don't have in there (any longer?). Here's the missing files for me:

** (inkscape:20571): WARNING **: Object with id="Buttons_flat-button" was not found in the document. Nothing exported.

** (inkscape:20598): WARNING **: Object with id="Buttons_flat-button-insensitive" was not found in the document. Nothing exported.

** (inkscape:20606): WARNING **: Object with id="Buttons_checked-flat-button" was not found in the document. Nothing exported.

** (inkscape:20614): WARNING **: Object with id="Buttons_checked-flat-button-hover" was not found in the document. Nothing exported.

** (inkscape:20622): WARNING **: Object with id="Buttons_checked-flat-button-active" was not found in the document. Nothing exported.

** (inkscape:20632): WARNING **: Object with id="Buttons_checked-flat-button-insensitive" was not found in the document. Nothing exported.

I have looked in the assets.svg for gtk 2 and verified that I don't see those ids. Any ideas? This causes checkboxes in nautilus and other locations to appear as a magenta square.

@nana-4
Copy link
Owner

nana-4 commented Jul 16, 2016

Exactly, the current GTK2 theme had various problems. Therefore, I just rebuilt it from scratch. Please try the latest one from repo.

@USBA
Copy link

USBA commented Jul 19, 2016

@nana-4
I don't like the new blue colour (color) when hoveing the mouse in sidebar of Gnome files.
And also now Flat-plat is looks like Paper theme.
Old colours are great.

@Skehmatics
Copy link

@el-zipo conversations about the color scheme might be better suited in issue #19

Also, consider forking the repo and changing the colors in gtk-3.0/_colors.scss to your tastes (remember to run the parse-sass.sh build script)

@USBA
Copy link

USBA commented Jul 19, 2016

@Skehmatics I didn't mention about the pink colour and also I don't like it.
I'm telling about the blue colour and the gray colour header bar.
White colour is great.
But gray colour is matches with paper icon theme.
But blue colour ????? :(

@jayarc
Copy link
Author

jayarc commented Jul 22, 2016

Nana-4 thanks for you response and thanks for you hard work putting this theme together. I will get the lastest code :) I've seen the way Adapta offers up a configuration file for the "major" colors in the theme, creating a $sass variable that's later available in all the stylesheets. I kind of assume there will be more people asking about that so, less future work. If I have the time soon I could put up a pull request.

@nana-4
Copy link
Owner

nana-4 commented Aug 7, 2016

@jayarc Ok, thanks!

@nana-4 nana-4 closed this as completed Aug 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants