Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usage of Node.js 16 causes deprecated warnings and requires upgrade to Node.js 20 #273

Closed
3 tasks
steve-todorov opened this issue Feb 4, 2024 · 3 comments · Fixed by #278
Closed
3 tasks

Comments

@steve-todorov
Copy link

Details

Github has decided to transition from Node.js 16 to Node.js 20. Because of this we're getting some deprecation notices such as this one:

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: nanasess/setup-chromedriver@v2.
For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Tasklist

  • Check the Github article
  • Assert what needs to be done in order to upgrade (if necessary make a list)
  • Upgrade to Node.js 20
@steve-todorov
Copy link
Author

steve-todorov commented Feb 6, 2024

@nanasess it looks to me like the only thing we need to change is this particular line:

runs:
using: 'node16'
main: 'dist/index.js'

The package.json file seems to be already using @types/node >= 20.
Is there anything else that's needed to be done?
Would you have time to make a release soon?

@nanasess
Copy link
Owner

nanasess commented Feb 7, 2024

@steve-todorov
Welcome to setup-chromedriver, thanks for the detailed issue.
It will be released today, Japan time.
Please wait a little longer.

@steve-todorov
Copy link
Author

Sweet! Many thanks for the fast response and reaction!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants