Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Black settings ask for python 3.8 compatible syntax but enterprise supports python 3.7 #342

Closed
aarchiba opened this issue Feb 20, 2023 · 2 comments
Labels

Comments

@aarchiba
Copy link
Contributor

pyproject.toml has a setting to determine which version of Python black should produce syntax for; this should be the oldest version on which enterprise is expected to run, but it isn't:

https://github.com/nanograv/enterprise/blob/master/pyproject.toml#L3

As result, black could reformat our code in a way that doesn't run on our test suite.

@AaronDJohnson
Copy link
Collaborator

Personal opinion: We should drop support for Python 3.7 and move to support 3.11 instead since 3.7 reaches EoL in 4 months (https://endoflife.date/python)

@vhaasteren
Copy link
Member

We removed 3.7 with #362

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants