Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test failure introduced by #175 #182

Closed
AJFSalomon opened this issue Apr 8, 2024 · 0 comments · Fixed by #183
Closed

Test failure introduced by #175 #182

AJFSalomon opened this issue Apr 8, 2024 · 0 comments · Fixed by #183

Comments

@AJFSalomon
Copy link
Contributor

I updated my own plugin project with the timeout change in test_and_deploy.yml introduced in #175, and it caused the following test failure after git push:

Invalid workflow file: .github/workflows/test_and_deploy.yml#L23
The workflow is not valid. .github/workflows/test_and_deploy.yml (Line: 23, Col: 5): Unexpected value 'timeout'

I was able to replicate the bug twice by creating brand new plugin templates with slightly different parameters.

I fixed the bug in my own project by replacing timeout: 30 with timeout-minutes: 30. I will file a PR for this, but I figured it was good to also file an issue since the cookiecutter test procedure did not catch the problem.

@Czaki Czaki linked a pull request Apr 8, 2024 that will close this issue
@Czaki Czaki closed this as completed in #183 Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant