Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #241 #242, Resolve static analysis warnings #243

Merged
merged 2 commits into from
May 31, 2022

Conversation

skliper
Copy link
Contributor

@skliper skliper commented May 18, 2022

Checklist (Please check before submitting)

Describe the contribution

Testing performed
CI + static analysis run

Expected behavior changes
None, just squashes static analysis warnings

System(s) tested on

  • Hardware: VM
  • OS: Ubuntu 18.04
  • Versions: Bundle main + apps + related static analysis resolution branches

Additional context
None

Third party code
None

Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC

@skliper skliper added the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label May 18, 2022
@skliper skliper added this to the Draco milestone May 18, 2022
@astrogeco astrogeco added CCB:Approved and removed CCB:Ready Ready for discussion at the Configuration Control Board (CCB) labels May 18, 2022
@astrogeco
Copy link
Contributor

CCB:2022-05-18 APPROVED

@skliper skliper force-pushed the fix241-static_analysis_fsw branch from d3cbb14 to a1cfa6e Compare May 24, 2022 15:28
@skliper skliper marked this pull request as ready for review May 24, 2022 15:29
@skliper
Copy link
Contributor Author

skliper commented May 24, 2022

Resolved conflicts and rebased on main, ready to merge (assuming CI passes).

@astrogeco astrogeco merged commit f6ff03b into nasa:main May 31, 2022
@skliper skliper deleted the fix241-static_analysis_fsw branch June 10, 2022 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resolve static analysis warnings in unit tests Resolve static analysis warnings in fsw
2 participants