Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for alternate checksum type indicated in Metadata PDU #99

Open
jphickey opened this issue Dec 8, 2021 · 0 comments
Open

Support for alternate checksum type indicated in Metadata PDU #99

jphickey opened this issue Dec 8, 2021 · 0 comments

Comments

@jphickey
Copy link
Contributor

jphickey commented Dec 8, 2021

Per the CCSDS blue book 727.0-B-5, section 5.2.5 - the metadata PDU has a 4-bit "checksum type" field. The description says:

Checksum algorithm identifier as registered in the SANA Checksum Types Registry.
Value zero indicates use of the legacy modular checksum.

It looks like CF only supports the legacy checksum, because it does not check this field at all, and there appears to be only one algorithm implemented. However, this is not as significant as the large file size issue (#95) because it does not otherwise change the format, here the result will be a simple failure of the validation check if there is a mismatch between peers.

This is an interoperability concern. If the intent is to only support legacy checksum, this should probably be documented in the release notes/version description document. If the intent is for full compliance with CCSDS book 727.0-B-5, then this is missing.

Interim recommendation for FSW is to at least check this field on receipt of a Metadata PDU, and reject if the checksum type field is set to anything other than '0'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants