Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use fixed size types for addresses and address offsets in tables/tlm/cmd #26

Open
3 tasks done
astrogeco opened this issue May 2, 2022 · 1 comment · May be fixed by #86
Open
3 tasks done

Use fixed size types for addresses and address offsets in tables/tlm/cmd #26

astrogeco opened this issue May 2, 2022 · 1 comment · May be fixed by #86
Labels
enhancement

Comments

@astrogeco
Copy link
Contributor

astrogeco commented May 2, 2022 •
edited by skliper
Loading

Checklist (Please check before submitting)

  • I reviewed the Contributing Guide.
  • I reviewed the README file to see if the feature is in the major future work.
  • I performed a cursory search to see if the feature request is relevant, not redundant, nor in conflict with other tickets.

Is your feature request related to a problem? Please describe.

Changing telemetry and table sizes depending on platform (32 vs 64 bit) when using the cpuaddr type in structures.

Describe the solution you'd like

Use cfe_es_memaddress and cfe_es_offset types for tables and telemetry and define those types as 64 bits. If space is an issue, users can redefine these types as 32-bit.

From CCB:2022-04-27

EDIT: CFE_ES_MemAddress_t and CFE_ES_MemOffset_t are the actual types that should be used

Describe alternatives you've considered

Leave as is, redefine telemetry sizes based on platform in the "ground system"

Additional context
None

Requester Info
Gerardo E. Cruz-Ortiz, NASA
@skliper
Copy link
Contributor

skliper commented May 2, 2022

See also nasa/cFE#2093

@skliper skliper changed the title Use cfe_es_memaddress and cfe_es_offset types for tables and telemetry Use cfe_es_memaddress and cfe_es_offset types for tables/tlm/cmd Jun 6, 2022
@skliper skliper mentioned this issue Jun 6, 2022
Open
3 tasks
@skliper skliper changed the title Use cfe_es_memaddress and cfe_es_offset types for tables/tlm/cmd Use fixed size types for addresses and address offsets in tables/tlm/cmd Jun 6, 2022
skliper pushed a commit to skliper/CS that referenced this issue Sep 9, 2022
@astrogeco
Merge pull request nasa#26 from skliper/fix24-strict_cppcheck_warnings
a75b4f4 
Fix nasa#24, Resolve strict cppcheck style warnings
thnkslprpt added a commit to thnkslprpt/CS that referenced this issue Jun 11, 2023
@thnkslprpt
Fix nasa#26, Use CFE_ES_MemAddress_t instead of cpuaddr in tables…
3a6c802 
…/tlm/cmd structs
@thnkslprpt thnkslprpt linked a pull request Jun 11, 2023 that will close this issue
Open
2 tasks
thnkslprpt added a commit to thnkslprpt/CS that referenced this issue Sep 5, 2023
@thnkslprpt
Fix nasa#26, Use CFE_ES_MemAddress_t instead of cpuaddr in tables…
7616fff 
…/tlm/cmd structs
thnkslprpt added a commit to thnkslprpt/CS that referenced this issue Sep 5, 2023
@thnkslprpt
Fix nasa#26, Use CFE_ES_MemAddress_t instead of cpuaddr in tables…
e36d0e6 
…/tlm/cmd structs
thnkslprpt added a commit to thnkslprpt/CS that referenced this issue Sep 5, 2023
@thnkslprpt
Fix nasa#26, Use CFE_ES_MemAddress_t instead of cpuaddr in tables…
7df1e3d 
…/tlm/cmd structs
thnkslprpt added a commit to thnkslprpt/CS that referenced this issue Mar 23, 2024
@thnkslprpt
Fix nasa#26, Use CFE_ES_MemAddress_t instead of cpuaddr in tables…
e51b7d2 
…/tlm/cmd structs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #26, Use CFE_ES_MemAddress_t instead of cpuaddr in tables/tlm/cmd structs thnkslprpt/CS
2 participants
@skliper @astrogeco