Fix #93, Remove file age check bug

[skliper]

Checklist (Please check before submitting)

• I reviewed the Contributing Guide.
• I signed and emailed the appropriate Contributor License Agreement to GSFC-SoftwareRelease@mail.nasa.gov and copied cfs-program@lists.nasa.gov.

Describe the contribution

• Fix File age check logic is wrong #93

Testing performed
CI and local check that files get produced as requested (1 per minute when configured to do so)

Expected behavior changes
Will produce the expected files, vs 17 per 10 minutes when configured to produce 1 per minute

System(s) tested on
Ubuntu 20.04

Additional context
None

Third party code
None

Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC

[skliper]

Note, could have also just broken the coupling between HK messages and age checks (either do it on a timer or w/ a separate processing message). Or just do a real age check instead of accumulating age. This change just makes it work like it used to when there wasn't a SB timeout.

[jphickey]

Looks OK for a basic workaround. I think we should revisit this issue with a more robust design, though - this still requires DS_SECS_PER_HK_CYCLE to be manually set to the same thing it was set to in SCH to generate the HK request. This seems fragile.

I'd recommend to at least have DS_FileTestAge do its own clock sample and figure out the real elapsed time since it was last invoked using the monotonic clock provided by the PSP (e.g. via CFE_PSP_GetTime) rather than believing some constant value. This shouldn't need to be configured at all.

[skliper]

I agree completely, this is just the basic revert of the bug introduced in 2.6.0. I only put this merge in to get a quick fix if possible.