Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
Call "strncpy" with the size parameter indicating the size of the destination buffer, rather than the input string length.
A buffer overflow was avoided due to a length check already in the code, but calling the function properly should avoid a warning.
Fixes #63
Testing performed
Build and run all tests
Send the
FM_GET_DIR_FILE_CC
andFM_GET_DIR_PKT_CC
and confirm correct behavior.Expected behavior changes
No compiler warnings.
No change to functionality.
System(s) tested on
Ubuntu 22.04
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.