Fix #66, remove compiler extensions from tbldefs #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not declare tables as "static" w/attribute "used", neither are needed, and build works fine without any special sauce. This also makes the table name consistent by removing the "Default" in the name - it is still the same table, the name does not need to change just because it happens to be the default value.
|
CCB 16 February 2023: Approved pending removal of missed instance. |
jphickey
added a commit
to jphickey/HS
that referenced
this pull request
Feb 16, 2023
corrects a whitespace issue from a previous PR
2 tasks
dzbaker
added a commit
that referenced
this pull request
Feb 16, 2023
HotFix #67, correct whitespace per clang-format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
Do not declare tables as "static" w/attribute "used", neither are needed, and build works fine without any special sauce.
This also makes the table name consistent by removing the "Default" in the name - it is still the same table, the name does not need to change just because it happens to be the default value.
Fixes #66
Testing performed
Build and run all tests
Run HS app and confirm normal startup, tables loaded
Expected behavior changes
None
System(s) tested on
Debian
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.