Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #48, Remove unintentionally repeated identical assert #49

Merged
merged 1 commit into from
May 4, 2023
Merged

Fix #48, Remove unintentionally repeated identical assert #49

merged 1 commit into from
May 4, 2023

Conversation

thnkslprpt
Copy link
Contributor

@thnkslprpt thnkslprpt commented Mar 5, 2023 •
edited
Loading

Checklist

Describe the contribution

Testing performed
GitHub CI actions (incl. Build + Run, Unit Tests etc.) all passing successfully.
Coverage unchanged:

  lines......: 100.0% (706 of 706 lines)
  functions..: 100.0% (36 of 36 functions)
  branches...: 100.0% (312 of 312 branches)

Expected behavior changes
Test code cleaner without unintentional (and redundant) duplicate assert.

Contributor Info
Avi Weiss @thnkslprpt

@dzbaker dzbaker merged commit 3e04a2e into nasa:main May 4, 2023
@thnkslprpt thnkslprpt deleted the fix-48-remove-repeated-assert branch May 4, 2023 20:33
@dmknutsen dmknutsen added this to the Equuleus milestone May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CCB:Approved Equuleus-rc1 unit-test
Projects
None yet
Milestone
Equuleus
Development

Successfully merging this pull request may close these issues.

Identical assert repeated twice (unintentionally)
4 participants
@thnkslprpt @dzbaker @dmknutsen @chillfig