Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent default CPU ID/Spacecraft ID between PC-Linux and other platforms #154

Closed
johnphamngc opened this issue Apr 21, 2020 · 4 comments · Fixed by #160
Closed

Inconsistent default CPU ID/Spacecraft ID between PC-Linux and other platforms #154

johnphamngc opened this issue Apr 21, 2020 · 4 comments · Fixed by #160
Labels
enhancement New feature or request
Milestone

Comments

@johnphamngc
Copy link

johnphamngc commented Apr 21, 2020

Describe the bug
The CPU ID/Spacecraft ID on Linux differs from the VxWorks build due to the Linux build deriving the value from the targets.cmake and other platforms deriving it from the value of [target name]_platform_cfg.h and [mission name]_mission_cfg.h

To Reproduce
Set CFE_MISSION_SPACECRAFT_ID in [mission name]_mission_cfg.h different than SPACECRAFT_ID in targets.cmake. Do same for CFE_PLATFORM_CPU_ID and the value in TGT. Build for Linux and a VxWorks target. CPU IDs will be different when attempting to run SBN

Expected behavior
The same default CPU IDs should show up across both platforms.

Code snips
It appears this is due to the Linux PSP using GLOBAL_CONFIGDATA in CFE's target_config.c and the other platforms using CFE_MISSION_SPACECRAFT_ID and CFE_PLATFORM_CPU_ID directly.

System observed on:

  • OS: [e.g. Linux 4.4]
  • Versions cFE 6.7.12 , PSP 1.4 for mcp750, Linux, sp0

Additional context
Add any other context about the problem here.

Reporter Info
John Pham, Northrop Grumman

@jphickey
Copy link
Contributor

FYI - as part of the exception handling changes in pull #160 this also updated the way these IDs are handled. The MCP750 implementation now matches the Linux and RTEMS in this regard.

@jphickey jphickey linked a pull request May 15, 2020 that will close this issue
@skliper
Copy link
Contributor

skliper commented May 15, 2020

@johnphamngc Feel free to reopen if the update referenced above (now in master) didn't resolve your issue.

@skliper skliper closed this as completed May 15, 2020
@skliper skliper added the enhancement New feature or request label May 15, 2020
@skliper skliper added this to the 1.5.0 milestone May 15, 2020
@johnphamngc
Copy link
Author

Should a bug/enhancement be filed against cFE to deprecate CFE_PLATFORM_CPU_ID, CFE_PLATFORM_CPU_NAME, CFE_MISSION_SPACECRAFT_ID as they're now configured by TGT_NAME, and SPACECRAFT_ID cmake variables?

@skliper
Copy link
Contributor

skliper commented May 18, 2020

Should a bug/enhancement be filed against cFE to deprecate CFE_PLATFORM_CPU_ID, CFE_PLATFORM_CPU_NAME, CFE_MISSION_SPACECRAFT_ID as they're now configured by TGT_NAME, and SPACECRAFT_ID cmake variables?

See nasa/cFE#710

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants