Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate network logic in pc-rtems to support generic targets #375

Open
skliper opened this issue Jan 4, 2023 · 0 comments · May be fixed by #376
Open

Separate network logic in pc-rtems to support generic targets #375

skliper opened this issue Jan 4, 2023 · 0 comments · May be fixed by #376
Assignees
@skliper
Labels
enhancement New feature or request

Comments

@skliper
Copy link
Contributor

skliper commented Jan 4, 2023

Is your feature request related to a problem? Please describe.
The only non-generic implementation in pc-rtems is the network setup, which prevents use on a generic target.

Describe the solution you'd like
Isolate/separate network setup to support source selection or similar configuration option. Consider configuring from target defs or similar to avoid changes required within psp.

Describe alternatives you've considered
Could make an additional psp, but doesn't seem worth duplicating all the pc-rtems code that isn't specific to pc's.

Additional context
Specific parts:

PSP/fsw/pc-rtems/src/cfe_psp_start.c

Lines 36 to 40 in a260e9c

#include <rtems/rtems_bsdnet.h>
#include <rtems/rtems_dhcp_failsafe.h>
#include <bsp.h>
extern int rtems_fxp_attach(struct rtems_bsdnet_ifconfig *config, int attaching);

PSP/fsw/pc-rtems/src/cfe_psp_start.c

Lines 67 to 84 in a260e9c

static unsigned char ethernet_address[6] = {0x00, 0x04, 0x9F, 0x00, 0x27, 0x61};
static char net_name_str[] = "fxp1";
static char ip_addr_str[] = "10.0.2.17";
static char ip_netmask_str[] = "255.255.255.0";
static struct rtems_bsdnet_ifconfig netdriver_config = {
.name = net_name_str,
.attach = rtems_fxp_attach,
.next = NULL,
.ip_address = ip_addr_str,
.ip_netmask = ip_netmask_str,
.hardware_address = ethernet_address
/* more options can follow */
};
struct rtems_bsdnet_config rtems_bsdnet_config = {
.ifconfig = &netdriver_config, .bootp = rtems_bsdnet_do_dhcp_failsafe, /* fill if DHCP is used*/
};

Might also benefit from making /mnt/eeprom a config param... depends on how/where this is actually set up by the PSP. Would be nice to shift away from "eeprom" and use generic "nonvol".

Requester Info
Jacob Hageman - NASA/GSFC
@skliper skliper added the enhancement New feature or request label Jan 4, 2023
@skliper skliper self-assigned this Jan 4, 2023
skliper added a commit to skliper/PSP that referenced this issue Jan 4, 2023
@skliper
Fix nasa#375, Separate network logic in pc-rtems to support generic t…
bd7db46 
…argets
@skliper skliper linked a pull request Jan 4, 2023 that will close this issue
Draft
2 tasks
skliper added a commit to skliper/PSP that referenced this issue Jan 5, 2023
@skliper
Fix nasa#375, removed network setup call (will squash later)
ef155d4
skliper added a commit to skliper/PSP that referenced this issue Mar 2, 2023
@skliper
Fix nasa#375, Separate network logic in pc-rtems to support generic t…
54824f8 
…argets
skliper added a commit to skliper/PSP that referenced this issue Mar 2, 2023
@skliper
Fix nasa#375, removed network setup call (will squash later)
20d6a15
skliper added a commit to skliper/PSP that referenced this issue Jul 17, 2023
@skliper
Fix nasa#375, Separate network logic in pc-rtems to support generic t…
4c86c67 
…argets
skliper added a commit to skliper/PSP that referenced this issue Jul 17, 2023
@skliper
Fix nasa#375, removed network setup call (will squash later)
5a38bcd
skliper added a commit to skliper/PSP that referenced this issue Sep 15, 2023
@skliper
Fix nasa#375, Separate network logic in pc-rtems to support generic t…
2ac5957 
…argets
skliper added a commit to skliper/PSP that referenced this issue Sep 15, 2023
@skliper
Fix nasa#375, removed network setup call (will squash later)
ca9ff99
skliper added a commit to skliper/PSP that referenced this issue Nov 14, 2023
@skliper
Fix nasa#375, Separate network logic in pc-rtems to support generic t…
1b2b747 
…argets
skliper added a commit to skliper/PSP that referenced this issue Nov 14, 2023
@skliper
Fix nasa#375, removed network setup call (will squash later)
f3bbe6b
skliper added a commit to skliper/PSP that referenced this issue Dec 12, 2023
@skliper
Fix nasa#375, Separate network logic in pc-rtems to support generic t…
34b7e04 
…argets
skliper added a commit to skliper/PSP that referenced this issue Dec 12, 2023
@skliper
Fix nasa#375, removed network setup call (will squash later)
5102e94
skliper added a commit to skliper/PSP that referenced this issue Dec 19, 2023
@skliper
Fix nasa#375, Separate network logic in pc-rtems to support generic t…
a988491 
…argets
skliper added a commit to skliper/PSP that referenced this issue Dec 19, 2023
@skliper
Fix nasa#375, removed network setup call (will squash later)
2718d39
skliper added a commit to skliper/PSP that referenced this issue Dec 19, 2023
@skliper
Fix nasa#375, removed network setup call (will squash later)
65c3258
skliper added a commit to skliper/PSP that referenced this issue Jan 11, 2024
@skliper
Fix nasa#375, Separate network logic in pc-rtems to support generic t…
c7e6ee4 
…argets
skliper added a commit to skliper/PSP that referenced this issue Jan 11, 2024
@skliper
Fix nasa#375, removed network setup call (will squash later)
4f2d699
skliper added a commit to skliper/PSP that referenced this issue Feb 26, 2024
@skliper
Fix nasa#375, Progress on pc-rtems generic target support
fd39b8a
pepepr08 added a commit to pepepr08/PSP that referenced this issue Feb 29, 2024
@pepepr08
Fix nasa#375, rename pc-rtems to generic-rtems
a698ef9
skliper added a commit to skliper/PSP that referenced this issue Aug 14, 2024
@skliper
Fix nasa#375, Separate network logic in pc-rtems to support generic t…
9215d7a 
…argets
skliper added a commit to skliper/PSP that referenced this issue Aug 14, 2024
@skliper
Fix nasa#375, removed network setup call (will squash later)
c2190f1
skliper added a commit to skliper/PSP that referenced this issue Aug 14, 2024
@skliper
Fix nasa#375, Progress on pc-rtems generic target support
22fe181
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skliper skliper

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #375, Separate network logic in pc-rtems to support generic targets skliper/PSP
1 participant
@skliper