Fix #116, 117+118 - Multiple cleanups related to array indexing and range checking

[jphickey]

Checklist (Please check before submitting)

• I reviewed the Contributing Guide.
• I signed and emailed the appropriate Contributor License Agreement to GSFC-SoftwareRelease@mail.nasa.gov and copied cfs-program@lists.nasa.gov.

Describe the contribution
These commits depend on eachother, so are combined into one PR to avoid conflicts related to splitting and merging.

Commit 1: Fixes #116, scrub types used for indexing and identification

Introduces header files and dedicated types for the purpose of indexing
and identification of SC objects and structures.  This include ATS/RTS
identification, time sequence numbers, word offsets, and command
numbers.

Use a separate typedef for each, and document its purpose/intent in the
description, then update all FSW to use the typedef rather than a simple
uint16.

Note - in places where the CMD/TLM interface were _not_ using a uint16,
the old type is kept.  This maintains backward compatibility of the I/F.

Commit 2: Fixes #117, change local array refs to object pointer

This changes all "info" table access to go through an object pointer
that is obtained via an accessor method.

Commit 3: Fixes #118, implement range checking functions

Adds inline functions to do range checking, and uses them in all places
where the same logic had been copied around.  This reduces repetition of
logic.

Introduces proper data types and wrapper functions to deal with the
different types of IDs and indices.

Testing performed
Build and run all tests (Pending run with BVT setup)

Expected behavior changes
Cleaner codebase with more consistent error checking (or at least one step toward that)

System(s) tested on
Debian

Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.

[github-advanced-security]

CodeQL-coding-standard found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.

[jphickey]

NOTE: had to add a fourth commit here (for #121), in order to resolve a (real/preexisting) bug that is now exposed due to the type cleanup.