Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #66, Re-acquire tbl data pointer in SC_ManageTable #67

Merged
merged 3 commits into from
Dec 15, 2022

Conversation

dmknutsen
Copy link
Contributor

Checklist (Please check before submitting)

Describe the contribution

Testing performed
Build and run all tests'

Expected behavior changes
SC functions nominally

System(s) tested on
Ubuntu 22.04 and 20.04 (workflows)

Contributor Info - All information REQUIRED for consideration of pull request
Dan Knusten
NASA/Goddard

@dmknutsen dmknutsen self-assigned this Dec 8, 2022
@dmknutsen dmknutsen added this to the Draco milestone Dec 8, 2022
@chillfig
Copy link
Contributor

chillfig commented Dec 8, 2022

Workflow suggest a small clang format change to sc_cmds.c in this commit (https://github.com/nasa/SC/actions/runs/3650643338/jobs/6166885287)

Also, this commit message and pull request title need to be amended to something like "Fix #66, Re-acquire tbl data pointer in SC_ManageTable" to satisfy the other half of the github format check.

@jphickey jphickey changed the title Re-acquire tbl data pointer in SC_ManageTable Fix #66, Re-acquire tbl data pointer in SC_ManageTable Dec 9, 2022
@jphickey
Copy link
Contributor

jphickey commented Dec 9, 2022

Updated to remove the void* cast and fix the commit message and stuff to make this pass the checks. There are still some code scanning issues but it looks like there is another pending PR that fixes those.

@dzbaker dzbaker merged commit 2c7b4d3 into nasa:main Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Table data pointer not successfully being re-acquired in SC_ManageTable
5 participants