You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
Some files are still written directly from the command handler (main task), see CFE_ES_WriteSysLogCmd for example. Some request the write from a background task using CFE_FS_RunBackgroundFileDump and CFE_FS_Background* routines, see CFE_ES_WriteERLogCmd. Then there's also the unique CFE_ES_RunPerfLogDump with it's own run function that doesn't utilize CFE_FS_RunBackgroundFileDump.
Side note - CFE_ES_SysLogDump does not check for CFE_FS_WriteHeader valid size (just >= 0)
Describe the solution you'd like
Scrub all file writes and implement a single pattern. This should standardize events, error handling, scheduling work, dump deconfliction, etc. Note there's multiple issues with overloaded EIDs in reporting errors, etc. Avoid additional complexity from "backwards compatible" event messages, etc.
Describe alternatives you've considered
If these really require different handling, summarize file write handling and document. Current design is challenging to analyze for file write timing impacts without in-depth knowledge of implementation.
Additional context #1588 documents some of the EventID issues
Requester Info
Jacob Hageman - NASA/GSFC
The text was updated successfully, but these errors were encountered:
Is your feature request related to a problem? Please describe.
Some files are still written directly from the command handler (main task), see
CFE_ES_WriteSysLogCmd
for example. Some request the write from a background task usingCFE_FS_RunBackgroundFileDump
and CFE_FS_Background* routines, seeCFE_ES_WriteERLogCmd
. Then there's also the uniqueCFE_ES_RunPerfLogDump
with it's own run function that doesn't utilizeCFE_FS_RunBackgroundFileDump
.Side note -
CFE_ES_SysLogDump
does not check for CFE_FS_WriteHeader valid size (just >= 0)Describe the solution you'd like
Scrub all file writes and implement a single pattern. This should standardize events, error handling, scheduling work, dump deconfliction, etc. Note there's multiple issues with overloaded EIDs in reporting errors, etc. Avoid additional complexity from "backwards compatible" event messages, etc.
Describe alternatives you've considered
If these really require different handling, summarize file write handling and document. Current design is challenging to analyze for file write timing impacts without in-depth knowledge of implementation.
Additional context
#1588 documents some of the EventID issues
Requester Info
Jacob Hageman - NASA/GSFC
The text was updated successfully, but these errors were encountered: