SB missing coverage in CFE_SB_AppInit, alternate config but suggested refactor/redesign

[skliper]

Is your feature request related to a problem? Please describe.
Uncovered code since it would require an alternate config where CFE_PLATFORM_EVS_MAX_EVENT_FILTERS is less than the defined number of filters:

     190                 :            :     /* Be sure the number of events to register for filtering
     191                 :            :     ** does not exceed CFE_PLATFORM_EVS_MAX_EVENT_FILTERS */
     192         [ -  + ]:         12 :     if (CFE_PLATFORM_EVS_MAX_EVENT_FILTERS < CfgFileEventsToFilter)
     193                 :            :     {
     194                 :          0 :         CfgFileEventsToFilter = CFE_PLATFORM_EVS_MAX_EVENT_FILTERS;
     195                 :            :     

here:

cFE/modules/sb/fsw/src/cfe_sb_task.c

Lines 190 to 195 in 5e41330

	/* Be sure the number of events to register for filtering
	** does not exceed CFE_PLATFORM_EVS_MAX_EVENT_FILTERS */
	if (CFE_PLATFORM_EVS_MAX_EVENT_FILTERS < CfgFileEventsToFilter)
	{
	CfgFileEventsToFilter = CFE_PLATFORM_EVS_MAX_EVENT_FILTERS;
	} /* end if */

Describe the solution you'd like
Consider refactor of self-filtering, unfriendly to ground management of filters. Generated events shouldn't spam to begin with, and be useful vs requiring self-filtering. Or if this pattern is retained the silent misconfiguration isn't great, could better utilize EVS registration error reporting. Either way this design isn't great. Could get coverage by modifying config, but really it'd just be broken (have user fix config vs silently not doing what the user requested).

Describe alternatives you've considered
See above.

Additional context
#1468

Requester Info
Jacob Hageman - NASA/GSFC

[jphickey]

See also #1669 .... I had also observed this when writing the functional test (can close the other as dupe).

[avan989]

Code Coverage is not possible without modifying the default configuration. No way to make CFE_PLATFORM_EVS_MAX_EVENT_FILTERS < CfgFileEventsToFilter without changing config.

Currently:

1. CFE_PLATFORM_EVS_MAX_EVENT_FILTERS is config to 8
2. CfgFileEventsToFilter is hardcoded to 0.

Reference ticket for the recommended fix.