CFE_ES_GetPoolBuf() return value is confusing

[CDKnightNASA]

On error, CFE_ES_GetPoolBuf() returns a status code, but on success, it returns the size allocated (which is actually the Size input parameter, so the return value is redundant.) I suggest either make the Size parameter an in/out parameter, or just return a CFE status and the caller can assume CFE_SUCCESS means the memory size requested was allocated.

cFE/modules/es/fsw/src/cfe_es_mempool.c

Line 424 in 318f345

int32 CFE_ES_GetPoolBuf(CFE_ES_MemPoolBuf_t *BufPtr, CFE_ES_MemHandle_t Handle, size_t Size)

[skliper]

Agreed, although in theory API change requires a "major update" unless we can do it by just adding an API and deprecating this one. If we do it here we might want to tackle the rest of the "multiple success return codes" issue:

• Deprecate multiple "success" code responses #483