Fix #1408, Use LogFullFlag instead of checking LogCount #2271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You have successfully added a new CodeQL configuration |
|
You have successfully added a new CodeQL configuration |
skliper
reviewed
Mar 29, 2023
modules/evs/fsw/src/cfe_evs_log.c
Outdated
| @@ -167,7 +167,7 @@ int32 CFE_EVS_WriteLogDataFileCmd(const CFE_EVS_WriteLogDataFileCmd_t *data) | |||
| OS_MutSemTake(CFE_EVS_Global.EVS_SharedDataMutexID); | |||
|
|
|||
| /* Is the log full? -- Doesn't matter if wrap mode is enabled */ | |||
| if (CFE_EVS_Global.EVS_LogPtr->LogCount == CFE_PLATFORM_EVS_LOG_MAX) | |||
| if (CFE_EVS_Global.EVS_LogPtr->LogFullFlag == true) | |||
There was a problem hiding this comment.
Suggestion if it's already a bool: if (CFE_EVS_Global.EVS_LogPtr->LogFullFlag)
thnkslprpt
force-pushed
the
fix-1408-use-LogFullFlag-to-check-for-log-full
branch
from
2056112
to
25b2fa3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Describe the contribution
LogFullFlaginstead of checkingLogCount == CFE_PLATFORM_EVS_LOG_MAXin event log logic #1408LogCount == CFE_PLATFORM_EVS_LOG_MAXreplaced byLogFullFlag == true(this is what that flag is for...).Testing performed
GitHub CI actions (incl. Functional Tests) all passing successfully.
Local tests with cFS suite confirm coverage overall unaffected.
Expected behavior changes
No change to behavior.
System(s) tested on
Intel(R) Celeron(R) N4100 CPU @ 1.10GHz x86_64
Debian GNU/Linux 11 (bullseye)
Current main branch of cFS.
Contributor Info
Avi Weiss @thnkslprpt