Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2543, consistent TIME values for TBL structures #2544

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

jphickey
Copy link
Contributor

@jphickey jphickey commented Apr 3, 2024

Checklist (Please check before submitting)

Describe the contribution
Use the CFE_TIME_SysTime_t type more consistently across TBL where time is being stored. Avoid using seconds/subseconds directly.

This also adds an initializer value for CFE_TIME_SysTime_t that has seconds/subseconds as zero.

Fixes #2543

Testing performed
Build and sanity check CFE, run all tests and workflows

Expected behavior changes
In general, nothing -- but some external tools might get tripped on the fact that the two uint32 values in TLM is now a sub-struct (CFE_TIME_SysTime_t) instead of being expressed directly as 2 uint32 values.

System(s) tested on
Debian

Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.

Use the CFE_TIME_SysTime_t type more consistently across TBL where
time is being stored.  Avoid using seconds/subseconds directly.

This also adds an initializer value for CFE_TIME_SysTime_t that
has seconds/subseconds as zero.
@jphickey jphickey added the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label Apr 3, 2024
@dzbaker dzbaker added CCB:Approved Indicates code review and approval by community CCB and removed CCB:Ready Ready for discussion at the Configuration Control Board (CCB) labels Apr 4, 2024
dzbaker added a commit to nasa/cFS that referenced this pull request Apr 5, 2024
*Combines:*

cFE equuleus-rc1+dev127

**Includes:**

*cFE*
- nasa/cFE#2541
- nasa/cFE#2544

Co-authored by: Drew Paettie <cazlo@users.noreply.github.com>
Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com>
@dzbaker dzbaker merged commit 993d9cd into nasa:main Apr 5, 2024
22 checks passed
dzbaker added a commit to nasa/cFS that referenced this pull request Apr 5, 2024
*Combines:*

cFE equuleus-rc1+dev127

**Includes:**

*cFE*
- nasa/cFE#2541
- nasa/cFE#2544

Co-authored by: Drew Paettie <cazlo@users.noreply.github.com>
Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com>
@jphickey jphickey deleted the fix-2543-tbl-time branch April 5, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates code review and approval by community CCB
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use consistent time definition for TBL subsystem data structures
2 participants